contra tactic and helper lemmas (in boolp.v) #1119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tragicus
force-pushed
the
contra
branch
3 times, most recently
from
31bba87 to
3e33513
Compare
Tragicus
added
the
TODO: MC2 port
Member
|
The changelog has been compromised. |
Tragicus
added a commit
to Tragicus/analysis
that referenced
this pull request
Jan 7, 2024
2 tasks
affeldt-aist
added a commit
that referenced
this pull request
Jan 8, 2024
* helper lemmas for contra (PR #1119) * rm pdegen, use more PropB --------- Co-authored-by: Reynald Affeldt <[email protected]>
affeldt-aist
added a commit
to affeldt-aist/analysis
that referenced
this pull request
Jan 9, 2024
* helper lemmas for contra (PR math-comp#1119) * rm pdegen, use more PropB --------- Co-authored-by: Reynald Affeldt <[email protected]>
proux01
pushed a commit
that referenced
this pull request
Jan 9, 2024
* helper lemmas for contra (PR #1119) * rm pdegen, use more PropB --------- Co-authored-by: Reynald Affeldt <[email protected]>
Member
|
Looks good! Thanks for porting this. I would not document "internals" of the tactic in the changelog, just the API. |
proux01
approved these changes
Jan 18, 2024
Collaborator
proux01
left a comment
proux01
left a comment
There was a problem hiding this comment.
Great, some nitpicking comments then let's merge.
Tragicus
force-pushed
the
contra
branch
2 times, most recently
from
e1626e7 to
56be54b
Compare
proux01
reviewed
Jan 18, 2024
Collaborator
|
Merging as soon as CI is happy. |
Collaborator
|
Thanks! |
proux01
removed
the
TODO: MC2 port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done/to do
Ports some work by Georges Gonthier on a tactic for proofs by contraposition.
It will need some testing, some discussion (at least regarding the
TOTHINKs) and maybe some cleanup.The CHANGELOG has not been updated and neither has the documentation been written.
CHANGELOG_UNRELEASED.mdCompatibility with MathComp 2.0
TODO: HB portto make sure someone ports this PR tothe
hierarchy-builderbranch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.