Skip to content

Conversation

@affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Nov 17, 2023

The setting of HB instances and the naming also is a bit different from master.
This has been partly discussed with @zstone1 .

Motivation for this change
Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

--

Co-authored-by: affeldt-aist <[email protected]>
Co-authored-by: Reynald Affeldt <[email protected]>
@affeldt-aist affeldt-aist requested a review from zstone1 November 17, 2023 01:27
Copy link
Contributor

@zstone1 zstone1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably move some of this stuff into topology.v, as you mentioned. But with the need to break up topology anyway, it's fine to leave it here for now

@affeldt-aist affeldt-aist merged commit e3a557e into math-comp:hierarchy-builder Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants