Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

fix(drawer): add missing foundation import in drawer #821

Merged
merged 3 commits into from
Apr 29, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/drawer/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ import {
MDCModalDrawerFoundation,
util,
} from '@material/drawer';
// @ts-ignore no .d.ts file
import {MDCListFoundation} from '@material/list/dist/mdc.list';
import {MDCListFoundation} from '@material/list/foundation';
import DrawerHeader from './Header';
import DrawerContent from './Content';
import DrawerSubtitle from './Subtitle';
Expand Down
2 changes: 1 addition & 1 deletion packages/drawer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
},
"dependencies": {
"@material/drawer": "^1.0.1",
"@material/list": "^0.41.0",
"@material/list": "^1.0.0",
"classnames": "^2.2.6",
"focus-trap": "^3.0.0",
"react": "^16.4.2"
Expand Down
3 changes: 3 additions & 0 deletions packages/list/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,9 @@ export default class List extends React.Component<ListProps, ListState> {
listItem.setAttribute(attr, value);
}
},
// TODO: implement
// https://github.com/material-components/material-components-web-react/issues/822
getAttributeForElementIndex: () => '',
/**
* Pushes class name to state.listItemClassNames[listItemIndex] if it doesn't yet exist.
*/
Expand Down
1 change: 0 additions & 1 deletion test/screenshot/golden.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"text-field/textArea": "b4c009f5f7637f7103380a2dd93bd6387d1ccc22d031323e6f0472949ce35881",
"text-field/standard": "61cf0ebade2a09263d3a015c26cde28b3b3e67ab9d9bb4c494ac4823b9e8000b",
"text-field/fullWidth": "26fa1e96054939384efb6427d93967bdbbc05ecc00bf7e4f13ab17cbe3e367fb",
"text-field/outlined": "91e95a9bfb4e3f75ba9bb6a7ccf6a379b944d4960aaffd4ca2e4026a3f3daa71",
"text-field/refTest": "742fe55ba0f3ca11c74beef5ea9737e2eaec37d9c8524552f3b06c6cb25f4157",
"top-app-bar/fixed": "7a2dd6318d62ac2eabd66f1b28100db7c15840ccb753660065fa9524db6435d6",
"top-app-bar/prominent": "2506ed2dd5f370c7bab69315d2daebd58b443d2b9e32bbaec762e40a8736309b",
Expand Down
1 change: 0 additions & 1 deletion test/screenshot/text-field/variants.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
export default [
'standard',
'fullWidth',
'outlined',
'textArea',
'refTest',
];