Clean up warning flags #2456
Merged
Clean up warning flags #2456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will also cleanup related sets of warning flags. |
ianegordon
approved these changes
Nov 16, 2017
ajsecord
added a commit
to ajsecord/bazel_ios_warnings
that referenced
this pull request
Nov 16, 2017
…be rationalized.
This was referenced Nov 16, 2017
jverkoey
approved these changes
Nov 16, 2017
…m to be supported by Kokoro?
ajsecord
force-pushed
the
fix-warning-flags
branch
from
f42682e to
be28aaf
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2456 +/- ##
==========================================
Coverage ? 44.14%
==========================================
Files ? 251
Lines ? 24478
Branches ? 2166
==========================================
Hits ? 10805
Misses ? 13650
Partials ? 23
Continue to review full report at Codecov.
|
randallli
approved these changes
Nov 17, 2017
This was referenced Nov 17, 2017
|
Travis is happy, merging. |
yarneo
pushed a commit
to yarneo/material-components-ios
that referenced
this pull request
Dec 1, 2017
* Documented, clarified, and cleaned up warning flags. * Fixed places where properties are missing `nonatomic`. * Removed unused MDC_DEPRECATION_WARNINGS. * Reviewer suggestions. * Changed -Wshadow-all back to -Wshadow, since -Wshadow-all doesn't seem to be supported by Kokoro?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Wunused-*flags.-Wunused-parameterflag.One cleanup ended up enabling
-Wcustom-atomic-properties, so I fixed those errors.