Small tweaks to application setup #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidfowl
commented
Aug 8, 2021
davidfowl
commented
- Close over WebApplicationBuilder for configuration and environment.
- Male explicit call to UseRouting so the error handler works
- Grouped middleware Use* before route Map*.
- Close over WebApplicationBuilder for configuration and environment. - Male explicit call to UseRouting so the error handler works - Grouped middleware Use* before route Map*.
- Enable nullable and removed a null check - Validate auth options on startup
Codecov Report
@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 94.95% 94.96% +0.01%
==========================================
Files 17 17
Lines 317 318 +1
==========================================
+ Hits 301 302 +1
Misses 16 16
Continue to review full report at Codecov.
|
martincostello
approved these changes
Aug 8, 2021
| }); | ||
|
|
||
| // Add user authentication with GitHub as an external OAuth provider | ||
| builder.Services.AddGitHubAuthentication(); | ||
|
|
||
| // Add Razor Pages to render the UI | ||
| builder.Services.AddRazorPages(); | ||
| builder.Services.AddRouting(); |
There was a problem hiding this comment.
Ah did I mix up which one is implicit?
There was a problem hiding this comment.
Yep this is implicit
| @@ -55,6 +55,7 @@ public static IServiceCollection AddGitHubAuthentication(this IServiceCollection | |||
| options.ClaimActions.MapJsonKey(GitHubAvatarClaim, "avatar_url"); | |||
| } | |||
| }) | |||
| .ValidateOnStart() | |||
davidfowl
commented
Aug 8, 2021
|
Thanks! |
davidfowl
commented
Aug 8, 2021
| @@ -52,7 +52,7 @@ public static IEndpointRouteBuilder MapTodoApiRoutes(this IEndpointRouteBuilder | |||
| ITodoService service, | |||
| CancellationToken cancellationToken) => | |||
| { | |||
| if (model is null || string.IsNullOrWhiteSpace(model.Text)) | |||
| if (string.IsNullOrWhiteSpace(model.Text)) | |||
There was a problem hiding this comment.
This is new in rc1, we use the nullability of the parameter to determine if we should call your method with null. dotnet/aspnetcore#32375
There was a problem hiding this comment.
Lots of nice little QoL and usability stuff coming in now 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.