Normalize paths relative to basePath in all cases #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paths that include the basePath as set in options on the APISpec instance were normalized to not have the basePath as part of each path. However, this didn't work with the Flask plugin as normalization occured before the plugin generated it's URLs. This fixes the issue by also normalizing paths after plugin processing in `add_path`. Fixes #78.
|
Apologies for the delay in getting to this. The behavior looks correct. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paths that include the basePath as set in options on the APISpec
instance were normalized to not have the basePath as part of each path.
However, this didn't work with the Flask plugin as normalization occured
before the plugin generated it's URLs.
This fixes the issue by also normalizing paths after plugin processing in
add_path.Fixes #78.