Fixes in Unresolved comment '# TODO: remove placeholding zeroed y' and Fixes in Unresolved comment '# TODO: add float values'. #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes in Unresolved comment '# TODO: remove placeholding zeroed y'. lines of code = 1 in sklbench\datasets\loaders.py:804
Originally it was like y = np.zeros((x.shape[0],))

Changed it to y = np.zeros(x.shape[0])
Fixes in Unresolved comment '# TODO: add float values'. lines of code = 1 in Found in [sklbench\utils\special_params.py:48]
I added a function in special_params.py called def float_range(start,stop,step) to accept float values
I tested it in Python:
import sklbench.utils.special_params as spl
spl.explain_range('[RANGE]add:1:5:1')
[1.0, 2.0, 3.0, 4.0, 5.0]
spl.explain_range('[RANGE]add:1.1:5.1:.2')
[1.1, 1.3, 1.5, 1.7, 1.9, 2.1, 2.3000000000000003, 2.5000000000000004, 2.7000000000000006, 2.900000000000001, 3.100000000000001, 3.300000000000001, 3.5000000000000013, 3.7000000000000015, 3.9000000000000017, 4.100000000000001, 4.300000000000002, 4.500000000000002, 4.700000000000002, 4.900000000000002, 5.100000000000002]
spl.explain_range('[RANGE]mul:1.1:5.1:.2')
However for the geometric progression, make sure the step value is greater than 1 as the result gets progressively smaller and will never converge. We can do a comparison for step size to be greater than 1 (currently not implemented)
spl.explain_range('[RANGE]mul:1.1:5.1:2')
[1.1, 2.2, 4.4]
spl.explain_range('[RANGE]pow:1.1:5.1:2')
[]
spl.explain_range('[RANGE]pow:1.1:10:2')
[]
spl.explain_range('[RANGE]pow:0.2:1.1:5.1:2')
[0.1702679845041569, 0.006810719380166277, 0.00027242877520665133]
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing