This repository was archived by the owner on Mar 10, 2024. It is now read-only.
Fixes issue with drag and drop when mobile shim is used #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I came across this issue today, would be nice to merge the proposed fix. |
|
The same problem hear! |
|
I would also appreciate it if this is being merged. |
Contributor
|
AFAIK the shim rewrite does not suffer from this problem. https://github.com/timruffles/ios-html5-drag-drop-shim/tree/rewrite |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the recommended shim for mobile (https://github.com/timruffles/ios-html5-drag-drop-shim) doesn't set effectAllowed (event.dataTransfer.effectAllowed) on dragover. It may be worth making an adjustment to that library, but since we already have a 'backup' way to deal with this in 'angular drag and drop list', I figured we may as well use it.