Skip to content

Conversation

@ljdelight
Copy link
Collaborator

Description:

The MapRouletteConnection.getRequestBodyAsString() method was getting the response body, and the method name now reflects that (renamed to getResponseBodyAsString()).

This change will break API users that happened to inherit or use the MapRouletteConnection.getRequestBodyAsString().

Unit Test Approach:

N/A

Test Results:

Tests pass,

@ljdelight ljdelight changed the title Fix method name 'getResponseBodyAsString' Fix method name 'MapRouletteConnection.getRequestBodyAsString' Mar 19, 2022
Copy link
Contributor

@mgcuthbert mgcuthbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@mgcuthbert mgcuthbert merged commit c842a34 into dev Mar 21, 2022
@ljdelight ljdelight deleted the lburson/typo branch April 15, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants