fix a bug where terrain data causing IndexOutOfRangeException

documentation/docs/05-changelog.md

@@ -1,10 +1,11 @@
-## CHANGELOG
+## CHANGELOG
  ### v.1.4.3
 *??/??/2018*
 ##### New Features
 ##### Improvements
 ##### Bug Fixes
-- Fix issue with UvModifier where it calculates roof uv positions wrong
+- Fix issue with UvModifier which caused wrong roof uv positions calculations.
+- Fix issue with data fetcher to handle failed connections properly, which caused IndexOutOfRangeException during tile loading/unloading.
 
 
  ### v.1.4.2

sdkproject/Assets/Mapbox/Unity/MeshGeneration/Factories/ImageDataFetcher.cs

@@ -29,10 +29,11 @@ public void FetchImage(CanonicalTileId canonicalTileId, string mapid, UnityTile
 			if (rasterTile.HasError)
 			{
 				FetchingError(tile, new TileErrorEventArgs(tile.CanonicalTileId, rasterTile.GetType(), tile, rasterTile.Exceptions));
-				return;
 			}
-
-			DataRecieved(tile, rasterTile);
+			else
+			{
+				DataRecieved(tile, rasterTile);
+			}
 		});
 	}
 }

sdkproject/Assets/Mapbox/Unity/MeshGeneration/Factories/TerrainDataFetcher.cs

@@ -22,7 +22,7 @@ public class TerrainDataFetcher : DataFetcher
 	public Action<UnityTile, TileErrorEventArgs> FetchingError = (t, s) => { };
 
 	//tile here should be totally optional and used only not to have keep a dictionary in terrain factory base
-	public void FetchTerrain(CanonicalTileId canonicalTileId, string mapid, UnityTile tile = null) 
+	public void FetchTerrain(CanonicalTileId canonicalTileId, string mapid, UnityTile tile = null)
 	{
 		var pngRasterTile = new RawPngRasterTile();
 		pngRasterTile.Initialize(_fileSource, canonicalTileId, mapid, () =>
@@ -31,8 +31,10 @@ public void FetchTerrain(CanonicalTileId canonicalTileId, string mapid, UnityTil
 			{
 				FetchingError(tile, new TileErrorEventArgs(canonicalTileId, pngRasterTile.GetType(), null, pngRasterTile.Exceptions));
 			}
-
-			DataRecieved(tile, pngRasterTile);
+			else
+			{
+				DataRecieved(tile, pngRasterTile);
+			}
 		});
 	}
 }

sdkproject/Assets/Mapbox/Unity/MeshGeneration/Factories/VectorDataFetcher.cs

@@ -19,10 +19,11 @@ public void FetchVector(CanonicalTileId canonicalTileId, string mapid, UnityTile
 			{
 				FetchingError(tile, new TileErrorEventArgs(tile.CanonicalTileId, vectorTile.GetType(), tile, vectorTile.Exceptions));
 				tile.VectorDataState = TilePropertyState.Error;
-				return;
 			}
-
-			DataRecieved(tile, vectorTile);
+			else
+			{
+				DataRecieved(tile, vectorTile);
+			}
 		});
 	}
 }