Skip to content

Fix satellite imagery on roof not working. #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 5, 2018
Merged

Fix satellite imagery on roof not working. #638

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35f5441
Fix satellite imagery on roof not working.
abhishektrip Apr 2, 2018
c3d3cb0
Remove commented code.
abhishektrip Apr 5, 2018
901793a
Merge commit '41cbdc7e412358c07337b916d759b231569d09ae' into satellit…
abhishektrip Apr 5, 2018
d54d695
Update changelog
abhishektrip Apr 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sdkproject/Assets/Mapbox/Unity/DataContainers/GeometryMaterialOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ public override Type ModifierType
return typeof(MaterialModifier);
}
}
[Tooltip("Use image texture from the Imagery source as texture for roofs. ")]
public bool projectMapImagery;
public UvMapType texturingType = UvMapType.Tiled;
public MaterialList[] materials = new MaterialList[2];
public AtlasInfo atlasInfo;
Expand Down
4 changes: 2 additions & 2 deletions ...ject/Assets/Mapbox/Unity/MeshGeneration/Modifiers/GameObjectModifiers/MaterialModifier.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public override void Run(VectorEntity ve, UnityTile tile)
var min = Math.Min(_options.materials.Length, ve.MeshFilter.mesh.subMeshCount);
var mats = new Material[min];

if (!_options.projectMapImagery)
if (_options.texturingType != UvMapType.Satellite)
{
for (int i = 0; i < min; i++)
{
Expand All @@ -37,7 +37,7 @@ public override void Run(VectorEntity ve, UnityTile tile)
{
for (int i = 0; i < min; i++)
{
mats[i] = Instantiate(_options.materials[i].Materials[UnityEngine.Random.Range(0, _options.materials[i].Materials.Length)]);
mats[i] = _options.materials[i].Materials[UnityEngine.Random.Range(0, _options.materials[i].Materials.Length)];
}

mats[0].mainTexture = tile.GetRasterData();
Expand Down