Skip to content

Conversation

wilhelmberg
Copy link
Contributor

@atripathi-mb could you please check if all tests are ✅ for you too?
Especially Decompress on OSX:

image

@wilhelmberg wilhelmberg added this to the S18.1.1 milestone Jan 16, 2018
@wilhelmberg wilhelmberg self-assigned this Jan 16, 2018
@abhishektrip
Copy link
Contributor

@BergWerkGIS All tests look good. Getting an error for RequestDnsError tests. The string being returned is worded differently.
image

@wilhelmberg
Copy link
Contributor Author

Dang, the error message seems to change with every other Unity version and platform.

@atripathi-mb thanks. Could you try again?

Copy link
Contributor

@abhishektrip abhishektrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green 💯

@wilhelmberg wilhelmberg merged commit c10aa23 into develop Jan 18, 2018
abhishektrip added a commit that referenced this pull request Feb 28, 2018
…ing-experiments

* commit '0ceb39815363646170bd8bc2e54c1ca64d45fb47':
  MBTilesCache: Windows fix for path and filenames with +260 chars
  fix Unity's bytecode stripping with IL2CPP discarding "ystem.Linq.Expressions.Expression"
  Auto refreshing cache (#521)
  Editor layer key fix (#506)
  Create PRODUCT_ROADMAP.md
  change MapId to Style URL in Map Image Editor (#536)
  Zoomable map scaling fix (#527)
  Add EditorConfig to enforce coding style (#508)
  [publish docs]
  [publish-docs]
  Remove redundant content (#494)
  Adding some clarification for inline documentation.
  Magnifier icon fix (#497)
  PreBuild script fix for Unity >= 2018.1
  Fix MapMatching and Decompression tests (#504)

# Conflicts:
#	sdkproject/Assets/Mapbox/Unity/Map/QuadTreeTileProvider.cs
@wilhelmberg wilhelmberg deleted the fix-tests-mapmatching-decompression branch March 17, 2018 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix MapMatcher tests once and for all Revisit tests

2 participants