CarPlay refactoring and bugfixing. #3219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximAlien
added
UI
MaximAlien
force-pushed
the
maxim/car-play-refactoring
branch
4 times, most recently
from
693f3ec to
884f728
Compare
MaximAlien
force-pushed
the
maxim/car-play-refactoring
branch
5 times, most recently
from
ff3ffa9 to
d08cce9
Compare
MaximAlien
commented
Aug 10, 2021
Contributor
Author
There was a problem hiding this comment.
Fixes #3224. There should be an ability to change MapView style URL similarly to iOS.
MaximAlien
commented
Aug 10, 2021
Comment on lines
165
to
191
Contributor
Author
There was a problem hiding this comment.
Delegate methods, which were added in scope of #3220.
MaximAlien
force-pushed
the
maxim/car-play-refactoring
branch
7 times, most recently
from
cee1849 to
107969b
Compare
MaximAlien
force-pushed
the
maxim/car-play-refactoring
branch
from
107969b to
76f3ac2
Compare
1ec5
reviewed
Aug 20, 2021
Contributor
1ec5
left a comment
1ec5
left a comment
There was a problem hiding this comment.
Mostly documentation nits, but the removal of previewMapStyleURL usage would be a regression. Maybe I’m misunderstanding the impetus for that change though.
MaximAlien
force-pushed
the
maxim/car-play-refactoring
branch
from
5c35d70 to
308505f
Compare
1ec5
approved these changes
Aug 20, 2021
Contributor
1ec5
left a comment
1ec5
left a comment
There was a problem hiding this comment.
Sorry, these suggestions didn’t take for some reason. Looks good overall.
…ack when template is being presented or dismissed. Improve documentation. Minor styling changes.
MaximAlien
force-pushed
the
maxim/car-play-refactoring
branch
from
a8969d9 to
033d827
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR brings some improvements and changes, which are needed for mapbox/mapbox-navigation-ios-examples#134.
Also fixes:
CarPlayManager.interfaceController.delegateshould not change internalCarPlayManagerbehavior. #3220Custom style cannot be applied forCarPlayMapViewController. #3224