Skip to content

Conversation

@Guardiola31337
Copy link
Contributor

@Guardiola31337 Guardiola31337 commented Apr 3, 2019

Description

Adds offline options (path and version) to navigation launcher

What's the goal?

Test #1829 within the drop-in UI > NavigationLauncherActivity > NavigationLauncher > MapboxNavigationActivity > NavigationView

How is it being implemented?

Add support to NavigationLauncherActivity / NavigationLauncher to retrieve / store offlinePath and offlineVersion options

How has this been tested?

Checklist

  • I have tested locally / staging (including SNAPSHOT upstream dependencies if needed)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • Publish testapp in Google Play internal test track

@codecov-io
Copy link

Codecov Report

Merging #1862 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #1862      +/-   ##
============================================
- Coverage     33.91%   33.86%   -0.06%     
  Complexity     1029     1029              
============================================
  Files           257      257              
  Lines          8761     8774      +13     
  Branches        662      664       +2     
============================================
  Hits           2971     2971              
- Misses         5528     5541      +13     
  Partials        262      262

@Guardiola31337 Guardiola31337 merged commit 5fb2dea into master Apr 3, 2019
@Guardiola31337 Guardiola31337 deleted the pg-offline-launcher branch April 3, 2019 22:00
@Guardiola31337 Guardiola31337 mentioned this pull request Apr 12, 2019
11 tasks
@Guardiola31337 Guardiola31337 modified the milestones: v0.35.0, v0.36.0 Apr 12, 2019
@Guardiola31337 Guardiola31337 mentioned this pull request Apr 17, 2019
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants