Add waypoint targets support into NavigationRoute #1640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
added
⚠️ DO NOT MERGE
Guardiola31337
force-pushed
the
pg-waypoint-targets
branch
from
60533ff to
c641dfc
Compare
Codecov Report
@@ Coverage Diff @@
## master #1640 +/- ##
============================================
+ Coverage 23.7% 23.84% +0.14%
Complexity 735 735
============================================
Files 194 194
Lines 8286 8303 +17
Branches 607 610 +3
============================================
+ Hits 1964 1980 +16
Misses 6137 6137
- Partials 185 186 +1 |
Guardiola31337
added
✓ ready for review
and removed
blocked: upstream
⚠️ DO NOT MERGE
danesfeder
approved these changes
Dec 19, 2018
Contributor
danesfeder
left a comment
danesfeder
left a comment
There was a problem hiding this comment.
@Guardiola31337 thanks for running with this and thanks for the quick turnaround / release @osana! 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waypoint_targetssupport intoNavigationRouteFixes #1630
Note: current branch is using MAS
SNAPSHOT- MAS4.3.0needs to be released and theSNAPSHOTdependency removed before this PR can merge.cc @osana