Fix voice instruction cache not getting initialized with injected speech player #1627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1627 +/- ##
===========================================
- Coverage 23.71% 23.7% -0.02%
Complexity 735 735
===========================================
Files 194 194
Lines 8281 8285 +4
Branches 608 608
===========================================
Hits 1964 1964
- Misses 6132 6136 +4
Partials 185 185 |
danesfeder
approved these changes
Dec 13, 2018
Contributor
danesfeder
left a comment
danesfeder
left a comment
There was a problem hiding this comment.
Thanks for the quick fix @Guardiola31337 and great catch @skienzl ✅
Guardiola31337
deleted the
pg-1625-voice-instruction-cache-speech-player
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VoiceInstructionCachenot getting initialized with injectedSpeechPlayerFixes #1625