Attempt to fix the coverage job #1601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1601 +/- ##
=========================================
Coverage 22.65% 22.65%
Complexity 700 700
=========================================
Files 189 189
Lines 8241 8241
Branches 609 609
=========================================
Hits 1867 1867
Misses 6191 6191
Partials 183 183 |
danesfeder
approved these changes
Dec 5, 2018
Contributor
danesfeder
left a comment
danesfeder
left a comment
There was a problem hiding this comment.
Thanks @springmeyer for eyes on this, let's give it a shot ✅
Contributor
Author
|
Its interesting that one of the runs above failed the coverage check because coverage dropped. (https://codecov.io/gh/mapbox/mapbox-navigation-android/compare/5d6bdd9c901e85dc944044d9673f7d28c981c9ec...df38c2977e6a38da7bcfae7fffc9206fbd7e5624/src/libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/RouteProcessorRunnable.java). I suspect there may be a non-determinative test lurking that is not running the same code each time. |
Contributor
Author
|
Ticketed the above problem at #1607 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
--no-daemonto the gradle args in an attempt to fix #1598