Changes to skip popup FRE #698
Conversation
BW-6033 http://ultimaker.atlassian.net/browse/BW-6033 We want to change the skip functionality for FRE to skip individual steps and not skipping over to the completed screen at specific printer steps. I removed the code to "Complete" FRE depending on what step we are on, and changed the popup spacing and some visual things.
pravs3
left a comment
pravs3
left a comment
There was a problem hiding this comment.
We also need to update the texts in the skip popup to reflect the new behavior. It currently says "This may skip other set-up procedures as well. You can revisit all steps of the set-up in the settings." which is no longer the case.
I like the idea of moving to the next FRE step with a slight delay which I think looks good visually, but since we are doing this lets also use the opportunity to do this for cases and not just when skipping to the next step i.e. also when normally moving to the next step at the end of every FRE step. That way this Timer can be reused.
src/qml/MoreporkUI.qml
Outdated
| interval: 200 | ||
| onTriggered: { | ||
|
|
||
| if (inFreStep) { |
There was a problem hiding this comment.
I think it would be better if calling skipFreStepAction() stays inside the button onClicked handler.
There was a problem hiding this comment.
@Praveen3012 I'm looking into updating the text for skipping FRE steps.
BW-6033
http://ultimaker.atlassian.net/browse/BW-6033
We want to change the skip functionality for FRE to skip individual steps and not skipping over to the completed screen at specific printer steps. I removed the code to "Complete" FRE depending on what step we are on, and changed the popup spacing and some visual things.