Skip to content

Fix accidental append if file already exist #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix accidental append if file already exist #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/appstore/appstore_download.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ func (t *appstore) downloadFile(src, dst string, progress *progressbar.ProgressB
}
defer res.Body.Close()

file, err := t.os.OpenFile(dst, os.O_CREATE|os.O_WRONLY, 0644)
file, err := t.os.OpenFile(dst, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0644)
if err != nil {
return fmt.Errorf("failed to open file: %w", err)
}
Expand Down Expand Up @@ -237,7 +237,7 @@ func (t *appstore) applyPatches(item downloadItemResult, acc Account, src, dst s
}
defer srcZip.Close()

dstFile, err := t.os.OpenFile(dst, os.O_CREATE|os.O_WRONLY, 0644)
dstFile, err := t.os.OpenFile(dst, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0644)
if err != nil {
return fmt.Errorf("failed to open file: %w", err)
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/appstore/appstore_download_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ var _ = Describe("AppStore (Download)", func() {

BeforeEach(func() {
var err error
tmpFile, err = os.OpenFile(fmt.Sprintf("%s.tmp", testFile.Name()), os.O_CREATE|os.O_WRONLY, 0644)
tmpFile, err = os.OpenFile(fmt.Sprintf("%s.tmp", testFile.Name()), os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0644)
Expect(err).ToNot(HaveOccurred())

outputPath = strings.TrimSuffix(tmpFile.Name(), ".tmp")
Expand Down
4 changes: 2 additions & 2 deletions pkg/appstore/appstore_replicate_sinf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ type ReplicateSinfInput struct {
func (t *appstore) ReplicateSinf(input ReplicateSinfInput) error {
zipReader, err := zip.OpenReader(input.PackagePath)
if err != nil {
return errors.New("failed to open zip reader")
return fmt.Errorf("failed to open zip reader: %w", err)
}

tmpPath := fmt.Sprintf("%s.tmp", input.PackagePath)
tmpFile, err := t.os.OpenFile(tmpPath, os.O_CREATE|os.O_WRONLY, 0644)
tmpFile, err := t.os.OpenFile(tmpPath, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0644)

if err != nil {
return fmt.Errorf("failed to open file: %w", err)
Expand Down
Loading