#9439 Save region details in order address edit. #9511
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Region is missing in admin order view after order edit. The reason is that the address only save region ID. This fixes AddressSave controller to save region code and name.
|
|
|
@heyqule thank you for Pull Request. Could you please please fix class constructor following our backward Compatibility requirement: Adding a constructor parameter Please, make new class property Thank you |
Fix code compatibility according to @okorshenko Change variable to private. Fix constructor based on Backward Compatible Development guide
|
@okorshenko Hi. Do you have a moment to review the update? |
|
Hi @heyqule Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Region is missing in admin order view after order edit. The reason is that the address only save region ID.
This fixes AddressSave controller to save region code and name.
Manual testing scenarios
State/Region should now changed to new region or keep existing region if there is no change.