Codacy warning fixes #8949
Closed
Codacy warning fixes #8949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orlangur
requested changes
May 17, 2017
| @@ -17,8 +22,7 @@ public function execute() | |||
| { | |||
| $data = $this->getRequest()->getPostValue(); | |||
| $isNew = $this->getRequest()->getParam('is_new'); | |||
| /** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */ | |||
| $resultRedirect = $this->resultRedirectFactory->create(); | |||
| $this->resultRedirect = $this->resultRedirectFactory->create(); | |||
There was a problem hiding this comment.
Why need this instead of local variable?
| __('We can\'t add the order status right now.') | ||
| ); | ||
| if ($this->updateStatus($isNew, $data, $statusCode) !== false) { | ||
| return $this->resultRedirect; |
There was a problem hiding this comment.
Such logic seems quite confusing to me.
Random piece of code is moved to a separate method which may return boolean or object :)
Please change method name to isStatusUpdated and return true instead of object there.
| } | ||
| return $this->resultRedirect->setPath( |
There was a problem hiding this comment.
Two returns is not a good practice. Simply change to
return $isNew
? $this->resultRedirect->setPath('sales/*/new')
: $this->resultRedirect->setPath('sales/*/edit' ...
| ['status' => $this->getRequest()->getParam('status')] | ||
| ); | ||
| } | ||
| return $this->resultRedirect->setPath('sales/*/'); |
There was a problem hiding this comment.
Where this new return comes from?
| } | ||
|
|
||
| /** | ||
| * Check if template body has a reference to the same config path |
|
Closing this PR for now. Feel free to reopen if you would like to continue at any time. |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Jun 21, 2024
[Bengals Team] Test Fixes and Automation Tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a number of errors and warnings reported by Codacy.
Contribution checklist