Product name not shown in message when trying to add more products to cart then there are in stock #8660
Conversation
basselalaraaj
changed the title
| @@ -106,6 +106,10 @@ public function checkQuoteItemQty(StockItemInterface $stockItem, $qty, $summaryQ | |||
| { | |||
| $result = $this->objectFactory->create(); | |||
| $result->setHasError(false); | |||
|
|
|||
| $product = $this->productFactory->create(); | |||
| $product->load($stockItem->getProductId()); | |||
There was a problem hiding this comment.
Why not use ProductRepository here? Is product name always missing or only in some cases?
There was a problem hiding this comment.
@orlangur the name is always missing, because there is no product available.
There was a problem hiding this comment.
If you need to load Product you have to rely on ProductRepostioryInterface::get method.
loading product using the load method of Product Model you are using deprecated method of Abstract Model https://github.com/magento/magento2/blob/develop/lib/internal/Magento/Framework/Model/AbstractModel.php#L526
|
|
||
| $product = $this->productFactory->create(); | ||
| $product->load($stockItem->getProductId()); | ||
| $stockItem->setProduct($product); |
There was a problem hiding this comment.
Also, there is unit test failure:
Fatal error: Call to undefined method Mock_StockItemInterface_837dff1c::setProduct() in /home/travis/build/magento/magento2/app/code/Magento/CatalogInventory/Model/StockStateProvider.php on line 112
Is there a way to achieve the same using only defined interfaces?
There was a problem hiding this comment.
@orlangur
This is weird, because the interface already loaded Magento\CatalogInventory\Model\Stock\Item
And there is a public function setProduct available.
In my system it is working fine, no errors.
There was a problem hiding this comment.
I do believe that the code works ;)
The problem is that this method is not part of StockItemInterface.
Lame way is just add setProduct to mock in failed test. The downside is that the code we have do not follow contract defined by StockItemInterface.
Better way is achieve the same correct behavior but use only defined contracts and do not rely on existing implementation. Why wrong product instance appear in StockItem at all? Of course, it may appear, that correct fix require much more efforts in such case breaking contract with setProduct call may be acceptable at it is lesser evil than having bug.
There was a problem hiding this comment.
as your method accepts StockItemInterface as parameter, you should rely just on the contract provided by this interface https://github.com/magento/magento2/blob/develop/app/code/Magento/CatalogInventory/Api/Data/StockItemInterface.php
setProduct does not belong to StockItemInterface.
And couldn't belong, because StockItemInterface represents a relation between Stock and Product. You can consider it as a link entity, which holds the information about "what product" "in which quantity" stored on "what stock"
| @@ -106,6 +106,10 @@ public function checkQuoteItemQty(StockItemInterface $stockItem, $qty, $summaryQ | |||
| { | |||
| $result = $this->objectFactory->create(); | |||
| $result->setHasError(false); | |||
|
|
|||
| $product = $this->productFactory->create(); | |||
| $product->load($stockItem->getProductId()); | |||
There was a problem hiding this comment.
If you need to load Product you have to rely on ProductRepostioryInterface::get method.
loading product using the load method of Product Model you are using deprecated method of Abstract Model https://github.com/magento/magento2/blob/develop/lib/internal/Magento/Framework/Model/AbstractModel.php#L526
|
|
||
| $product = $this->productFactory->create(); | ||
| $product->load($stockItem->getProductId()); | ||
| $stockItem->setProduct($product); |
There was a problem hiding this comment.
as your method accepts StockItemInterface as parameter, you should rely just on the contract provided by this interface https://github.com/magento/magento2/blob/develop/app/code/Magento/CatalogInventory/Api/Data/StockItemInterface.php
setProduct does not belong to StockItemInterface.
And couldn't belong, because StockItemInterface represents a relation between Stock and Product. You can consider it as a link entity, which holds the information about "what product" "in which quantity" stored on "what stock"
|
Hi @basselalaraaj |
|
@basselalaraaj Closing this PR for now due to inactivity. Please reopen and check the review comments if you wish to continue work on it anytime. |
Preconditions
Magento 2.1.x
Steps to reproduce
Set the stock of a product to 20.
Add the same product to the cart with qty greater then 20.
Expected result
A message saying 'We don't have as many "<product_name>" as you requested'.
Actual result
Fixes #8560