Escape Js Quote "confirmRemoveMessage" on WishList view

[bchatard]

Escape confirmRemoveMessage on wishlist view

Exampe in French: Êtes-vous sûr de vouloir supprimer cet article de votre liste d'envie ==> Êtes-vous sûr de vouloir supprimer cet article de votre liste d'envie

[slavvka]

Hi @bchatard. Could you please tell me how did you manage to see this message as it isn't used in JS code?

[bchatard]

In Wish List view (http://my-site.com/wishlist/index/index/wishlist_id/{wishlist_id}/

There is a form (#wishlist-view-form) which have an attribute data-mage-init. This attribute contain this (in English)

data-mage-init='{"wishlist":{
          "addToCartUrl":{"action":"http:\/\/my-site.com\/wishlist\/index\/cart\/","data":{"item":"%item%","uenc":"aHR0cDovL3NhbmRib3gubWFnZW50bzIuZGV2L3dpc2hsaXN0L2luZGV4L2luZGV4L3dpc2hsaXN0X2lkLzEv"}},
          "confirmRemoveMessage":"Are you sure you want to remove this product from your Wish List?",
          "addAllToCartUrl":{"action":"http:\/\/my-site.com\/wishlist\/index\/allcart\/","data":{"wishlist_id":"1","uenc":"aHR0cDovL3NhbmRib3gubWFnZW50bzIuZGV2L3dpc2hsaXN0L2luZGV4L2luZGV4L3dpc2hsaXN0X2lkLzEv"}},
          "commentString":""},
          "validation": {}}'

But if the field confirmRemoveMessage contain a ' the JSON is not valid.
The page is not fully loaded (missing dynamic block on left) and the following javascript error is thrown

data-mage-init='{"wishlist":{
          "addToCartUrl":{"action":"http:\/\/my-site.com\/wishlist\/index\/cart\/","data":{"item":"%item%","uenc":"aHR0cDovL3NhbmRib3gubWFnZW50bzIuZGV2L3dpc2hsaXN0L2luZGV4L2luZGV4L3dpc2hsaXN0X2lkLzEv"}},
          "confirmRemoveMessage":"Êtes-vous sûr de vouloir supprimer cet article de votre liste d'envie",
          "addAllToCartUrl":{"action":"http:\/\/my-site.com\/wishlist\/index\/allcart\/","data":{"wishlist_id":"1","uenc":"aHR0cDovL3NhbmRib3gubWFnZW50bzIuZGV2L3dpc2hsaXN0L2luZGV4L2luZGV4L3dpc2hsaXN0X2lkLzEv"}},
          "commentString":""},
          "validation": {}}'

[slavvka]

Hi @bchatard, Thank you for your contribution but your PR has been declined since mentioned string isn't used anymore so it has been removed. See 0b5292.