Skip to content

Preserve existing store labels when updating attribute option via API #40095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

mimou78
Copy link

@mimou78 mimou78 commented Jul 23, 2025

Description (*)

This PR fixes an issue where updating a product attribute option via the API endpoint:

PUT /V1/products/attributes/byAttributeCode/options/byOptionId

would unintentionally erase store-specific labels that were not included in the payload.

Magento's current implementation of \Magento\Eav\Model\Entity\Attribute\OptionManagement::saveOption() overwrites all store_labels for an option when updating just one, instead of merging them. This fix introduces logic to preserve existing store labels and only update those explicitly provided.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Attribute Option Label Gets Overwritten When Updating Store Labels #40093

Manual testing scenarios (*)

  1. Create an attribute option with multiple store labels (e.g., for France and Germany).
  2. Use the API to update only one store label:
 {
     "option_id": 1234,
     "store_labels": [
       {
         "store_id": 2,
         "label": "Bleu updated"
       }
     ]
   }
  1. Use the API again to update another store label only:
{
  "option_id": 1234,
  "store_labels": [
    {
      "store_id": 3,
      "label": "Blau updated"
    }
  ]
}
  1. Expected result: both store labels (store 2 and store 3) remain intact and updated accordingly.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Jul 23, 2025

Hi @mimou78. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

Mohamed El Mrabet and others added 5 commits July 23, 2025 14:31
- Added condition for PR marked as Changes Requested.
- Added condition for the issue close to remove from the project.
Removed condition PR changes requested
Added copyright information in the file
@mimou78
Copy link
Author

mimou78 commented Jul 23, 2025

@magento run all tests

@mimou78 mimou78 changed the title Fix: Preserve existing store labels when updating attribute option via API (issue #40093) Preserve existing store labels when updating attribute option via API (issue #40093) Jul 23, 2025
@mimou78 mimou78 changed the title Preserve existing store labels when updating attribute option via API (issue #40093) Preserve existing store labels when updating attribute option via API Jul 23, 2025
@mimou78
Copy link
Author

mimou78 commented Jul 23, 2025

@magento run Unit Tests

@mimou78 mimou78 marked this pull request as draft July 23, 2025 16:45
glo24157 and others added 2 commits July 23, 2025 18:24
- Added condition for PR marked as Changes Requested.
- Added condition for the issue close to remove from the project.
@mimou78
Copy link
Author

mimou78 commented Jul 23, 2025

@magento run Static Tests

@mimou78
Copy link
Author

mimou78 commented Jul 23, 2025

@magento run Integration Tests

@mimou78
Copy link
Author

mimou78 commented Jul 23, 2025

@magento run Functional Tests CE

@mimou78
Copy link
Author

mimou78 commented Jul 24, 2025

@magento run Functional Tests B2B

@mimou78
Copy link
Author

mimou78 commented Jul 24, 2025

@magento run all test

Copy link

Failed to run the builds. Please try to re-run them later.

@mimou78 mimou78 marked this pull request as ready for review July 24, 2025 08:53
@mimou78
Copy link
Author

mimou78 commented Jul 24, 2025

@magento run all tests

@mimou78 mimou78 marked this pull request as draft July 26, 2025 09:23
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 29, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
Status: Pending Review
Development

Successfully merging this pull request may close these issues.

Attribute Option Label Gets Overwritten When Updating Store Labels
2 participants