Allow caching of product review list #3556
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@ljrweb: you may be interested in this :) |
Member
Author
|
Seems this PR took so long to process someone found and made the same fix in commit 90ce2db. :) Closing. MAGETWO-49918: Extra Ajax Requests on PDP |
magento-engcom-team
pushed a commit
that referenced
this pull request
Dec 30, 2018
[TSG] MFTF for 2.3 (pr10) (2.3.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product reviews are loaded via ajax, which is defeating the true value of varnish on anonymous product views since
mage/bootstrap.jsis callingajaxSetupand settingcacheto false, resulting in an anti-cache param being added to the URL by jQuery. The information here is public and catchable information which needs to be cached in varnish for proper performance and scaling. Removing the anti-cache header on this one request results in the entire product view page being catchable by varnish. The proper tags are in-fact already in place on the ajax request so that the content will be properly flushed when the catalog_product_ID tag is purged.