Skip to content

Conversation

@mwr
Copy link
Contributor

@mwr mwr commented Feb 26, 2016

In Magento\TestFramework\Db\Mysql for all mysql commands --defaults-extra-file is used to define a custom .cnf file providing the mysql configuration.
Problem is, that the cnf-file provided using the parameter --default-extra-file is overwriten by a configuration under ~/my.cnf. Thus resulting in a invalid mysql connection configuration and furthermore the tests will fail.
To prevent an error due this issue, this pull request will change the parameter to --defaults-file which is not overwritten by other configuration files.

Also see mysql docs here: http://dev.mysql.com/doc/refman/5.7/en/mysqldump.html#option_mysqldump_defaults-extra-file

@vkorotun vkorotun added the PS label Feb 29, 2016
@arkadiych
Copy link
Contributor

@mwr, you should sign Contributor License Agreement.

@okorshenko okorshenko self-assigned this Mar 2, 2016
@mwr
Copy link
Contributor Author

mwr commented Mar 2, 2016

I've done that, but it still shows "not signed yet"

@mwr
Copy link
Contributor Author

mwr commented Mar 2, 2016

in my other pull request it is recognized correctly, strange.

#3440

@okorshenko
Copy link
Contributor

I've done that, but it still shows "not signed yet"

@mwr , thank you for letting us know. We will analyze this issue

@Zatara7
Copy link

Zatara7 commented Mar 2, 2016

@mwr Could you please provide some examples of when this error happened?

@mwr
Copy link
Contributor Author

mwr commented Mar 2, 2016

Well whenever you are using a different mysql connection than defined in your ~/my.cnf.
We had this issue on our build, dev and staging environment, where we have like 2 or 3 different mysql versions on the same machine or within a docker container or on a completely different machine.

So this patch ensures the usage of the generated cnf file for integration tests.

@magento-team magento-team merged commit e8b6825 into magento:develop Mar 3, 2016
@okorshenko
Copy link
Contributor

@mwr Your Pull Request merged to develop branch. Thank you for contribution!

@mwr
Copy link
Contributor Author

mwr commented Jul 26, 2017

@jsiefer the problem was that the file provided via the parameter --default-extra-file is overwritten by a ~/my.cnf file. So basically the configuration provided with --default-extra-file was ignored and the one in ~/my.cnf was preferred, which is not what is expected in this scenario.

magento-engcom-team pushed a commit that referenced this pull request Jan 2, 2019
[EngCom] Public Pull Requests - GraphQL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants