Skip to content

Replace repetitive actions with Action Groups in StorefrontProductNameWithDoubleQuoteTest #34256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Replace repetitive actions with Action Groups in StorefrontProductNameWithDoubleQuoteTest #34256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72d76fc
Refactoring-StorefrontProductNameWithDoubleQuoteTest
kate-kyzyma Oct 6, 2021
aafadcf
Merge branch '2.4-develop' into Refactoring-StorefrontProductNameWith…
eduard13 Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 28 additions & 9 deletions ...est/StorefrontProductNameWithDoubleQuoteTest/StorefrontProductNameWithDoubleQuoteTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,22 +42,41 @@
<comment userInput="Adding the comment to replace CliIndexerReindexActionGroup action group ('indexer:reindex' commands) for preserving Backward Compatibility" stepKey="reindex"/>

<!--Check product in category listing-->
<amOnPage url="{{StorefrontCategoryPage.url($$createCategory.custom_attributes[url_key]$$)}}" stepKey="goToCategoryPage"/>
<actionGroup ref="StorefrontNavigateCategoryPageActionGroup" stepKey="goToCategoryPage">
<argument name="category" value="$createCategory$"/>
</actionGroup>

<seeElement selector="{{StorefrontCategoryProductSection.ProductImageByNameAndSrc(SimpleProductNameWithDoubleQuote.name, ProductImage.fileName)}}" stepKey="seeCorrectImageCategoryPage"/>
<see selector="{{StorefrontCategoryProductSection.ProductTitleByName(SimpleProductNameWithDoubleQuote.name)}}" userInput="{{SimpleProductNameWithDoubleQuote.name}}" stepKey="seeCorrectNameCategoryPage"/>
<see selector="{{StorefrontCategoryProductSection.ProductPriceByName(SimpleProductNameWithDoubleQuote.name)}}" userInput="${{SimpleProductNameWithDoubleQuote.price}}" stepKey="seeCorrectPriceCategoryPage"/>
<actionGroup ref="AssertStorefrontProductIsPresentOnCategoryPageActionGroup" stepKey="seeCorrectNameCategoryPage">
<argument name="productName" value="{{SimpleProductNameWithDoubleQuote.name}}"/>
</actionGroup>
<actionGroup ref="StorefrontAssertProductPriceOnCategoryPageActionGroup" stepKey="seeCorrectPriceCategoryPage">
<argument name="productName" value="{{SimpleProductNameWithDoubleQuote.name}}"/>
<argument name="productPrice" value="{{SimpleProductNameWithDoubleQuote.price}}"/>
</actionGroup>

<!--Open product display page-->
<click selector="{{StorefrontCategoryProductSection.ProductTitleByName(SimpleProductNameWithDoubleQuote.name)}}" stepKey="clickProductToGoProductPage"/>
<waitForPageLoad stepKey="waitForProductDisplayPageLoad"/>
<see selector="{{StorefrontProductInfoMainSection.productName}}" userInput="{{SimpleProductNameWithDoubleQuote.name}}" stepKey="seeCorrectName"/>
<actionGroup ref="StorefrontOpenProductFromCategoryPageActionGroup" stepKey="clickProductToGoProductPage">
<argument name="productName" value="{{SimpleProductNameWithDoubleQuote.name}}"/>
</actionGroup>
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForProductDisplayPageLoad"/>
<actionGroup ref="StorefrontAssertProductNameOnProductPageActionGroup" stepKey="seeCorrectName">
<argument name="productName" value="{{SimpleProductNameWithDoubleQuote.name}}"/>
</actionGroup>
<actionGroup ref="StorefrontAssertProductSkuOnProductPageActionGroup" stepKey="seeCorrectSku">
<argument name="productSku" value="{{SimpleProductNameWithDoubleQuote.sku}}"/>
</actionGroup>
<see selector="{{StorefrontProductInfoMainSection.productPrice}}" userInput="${{SimpleProductNameWithDoubleQuote.price}}" stepKey="seeCorrectPrice"/>
<seeElement selector="{{StorefrontProductInfoMainSection.productImageSrc(ProductImage.fileName)}}" stepKey="seeCorrectImage"/>
<see selector="{{StorefrontProductInfoMainSection.stock}}" userInput="In Stock" stepKey="seeInStock"/>
<see selector="{{StorefrontNavigationSection.breadcrumbs}}" userInput="$$createCategory.name$$" stepKey="seeCorrectBreadCrumbCategory"/>
<see selector="{{StorefrontNavigationSection.breadcrumbs}}" userInput="{{SimpleProductNameWithDoubleQuote.name}}" stepKey="seeCorrectBreadCrumbProduct"/>
<actionGroup ref="AssertStorefrontProductStockStatusOnProductPageActionGroup" stepKey="seeInStock">
<argument name="productStockStatus" value="In Stock"/>
</actionGroup>
<actionGroup ref="AssertStorefrontBreadcrubmsAreShownActionGroup" stepKey="seeCorrectBreadCrumbCategory">
<argument name="breadcrumbs" value="$$createCategory.name$$"/>
</actionGroup>
<actionGroup ref="AssertStorefrontBreadcrubmsAreShownActionGroup" stepKey="seeCorrectBreadCrumbProduct">
<argument name="breadcrumbs" value="{{SimpleProductNameWithDoubleQuote.name}}"/>
</actionGroup>

<!--Remove product-->
<actionGroup ref="DeleteProductUsingProductGridActionGroup" stepKey="deleteProduct">
Expand Down