-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Resolve warnings in PHPMD execution Fixes #33430 #33432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Unit Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run WebAPI Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
I did QA for this PR: Before these changes applied: Click to toggle the output
After changes applied: Click to toggle the output
|
@magento run Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@sivaschenko, can it be added to the Platform Health project? |
@magento run Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AntonEvers Thanks for PR. Please use composer v2 for update
composer.lock
Outdated
}, | ||
"platform-dev": [] | ||
"platform-dev": [], | ||
"plugin-api-version": "1.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use composer v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is important
Should be merged after #33225 |
@AntonEvers Please resolve merge conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AntonEvers,
Could you resolve the conflict and double-check your changes after the #33569 was merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @AntonEvers
Thank you for your contribution.
Could you please resolve merge conflicts.
Thank you in advance.
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Merge conflict resolved. Results after merge are OK:
|
Hello @AntonEvers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Hi @AntonEvers, thank you for your contribution! |
Description (*)
fix the exceptions mentioned in #33430
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
vendor/bin/phpmd app/code ansi dev/tests/static/testsuite/Magento/Test/Php/_files/phpmd/ruleset.xml
You should see no execution errors or warnings, just phpmd violations
Questions or comments
Contribution checklist (*)