[View] Removed extra space in link and script tag #32919

srsathish92 · 2021-04-30T19:07:58Z

Description (*)

This PR helps to change extra spaces into single space in <link> and <script> tag.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

./vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist lib/internal/Magento/Framework/View/Test/Unit/Page/Config/RendererTest.php
Open the store and see <link> and <script> tag using view source code.
<link> and <script> should be without double spaces between attributes.

Actual Result:

Excepted Result:

Questions or comments

Please let me your suggestions if any

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] [View] Removed extra space in link and script tag #32920: [View] Removed extra space in link and script tag

m2-assistant · 2021-04-30T19:08:00Z

Hi @srsathish92. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

srsathish92 · 2021-04-30T19:08:51Z

@magento run all tests

magento-automated-testing · 2021-04-30T19:08:55Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

srsathish92 · 2021-04-30T19:11:10Z

@magento create issue

Den4ik · 2021-04-30T21:27:18Z

@magento run Functional Tests EE, Functional Tests B2B

magento-automated-testing · 2021-04-30T21:27:22Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

srsathish92 · 2021-05-01T06:02:46Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-05-01T06:02:54Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

srsathish92 · 2021-05-01T18:37:20Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-05-01T18:37:28Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik

Hi @srsathish92 Thanks for your contribution

magento-engcom-team · 2021-05-03T12:26:50Z

Hi @Den4ik, thank you for the review.
ENGCOM-9060 has been created to process this Pull Request
✳️ @Den4ik, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

Den4ik · 2021-05-07T17:20:33Z

I'm not sure that usage of multiple spaces in attributes is a good practice and useful use case

engcom-Delta · 2024-02-09T10:03:56Z

Hi @srsathish92 , Thanks for your contribution.Please resolve the conflicts to move ahead on this PR

engcom-Delta

Please resolve the conflicts on this PR

…o cleanup/remove-extra-space-in-link-script-tag

srsathish92 · 2024-03-07T06:14:46Z

@magento run all tests

…ript-tag

engcom-November · 2024-05-21T08:12:08Z

@magento run all tests

engcom-November · 2024-05-21T09:48:10Z

This is a code-quality pr, no manual testing is required.

As the builds are failing moving this to Extended testing.

engcom-November · 2024-05-21T10:49:42Z

@magento run all tests

engcom-November · 2024-05-21T12:49:01Z

@magento run Static Tests, Integration Tests, Functional Tests B2B, Functional Tests CE, Functional Tests EE, WebAPI Tests

engcom-November · 2024-05-22T06:02:11Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, WebAPI Tests

engcom-November · 2024-05-22T09:38:22Z

For functional tests, repeating failures are known issues and are flaky.

Functional Tests B2B:
1st Run:

2nd Run:

Known issues:
ACQE-6523 - AdminReorderWithCatalogPriceRuleDiscountTest

Functional Tests CE:
1st Run:

2nd Run:

Known issues:
ACQE-6590 - AdminCheckConfigurationForPayPalExpressCheckoutInUnitesStatesTest

Functional Tests EE:
1st Run:

2nd Run:

Known issues:
ACQE-6523 - AdminReorderWithCatalogPriceRuleDiscountTest
ACQE-6331 - StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest

engcom-November · 2024-05-22T09:51:06Z

WebAPI repeating failure is known issue and is flaky.

1st Run:

2nd Run:

Known issue:
ACP2E-3082 - testSendNegotiableQuoteCannotResend

Hence moving this to Merge in Progress

Removed extra space in link and script tag

63c8298

magento-engcom-team added Component: View Release Line: 2.4 Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Apr 30, 2021

srsathish92 changed the title ~~[Framework] Removed extra space in link and script tag~~ [View] Removed extra space in link and script tag Apr 30, 2021

m2-community-project bot added the Progress: pending review label Apr 30, 2021

m2-assistant bot mentioned this pull request Apr 30, 2021

[Issue] [View] Removed extra space in link and script tag #32920

Closed

5 tasks

Den4ik self-assigned this Apr 30, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Apr 30, 2021

Den4ik added the Cleanup label Apr 30, 2021

m2-community-project bot added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels May 3, 2021

Den4ik approved these changes May 3, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels May 3, 2021

Den4ik added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label May 3, 2021

nurullah mentioned this pull request Aug 6, 2023

CSS file is deferred when CSS element has defer attribute in default_head_blocks.xml. #37814

Open

5 tasks

engcom-Delta added Progress: needs update and removed Progress: ready for testing labels Feb 9, 2024

engcom-Delta requested changes Feb 12, 2024

View reviewed changes

m2-community-project bot assigned engcom-Delta Feb 12, 2024

sidolov added Partner: ITG Commerce and removed Partner: Ziffity labels Mar 4, 2024

srsathish92 added 2 commits March 7, 2024 11:39

Resolve Conflicts

3acc814

Merge branch '2.4-develop' of https://github.com/magento/magento2 int…

23f3eee

…o cleanup/remove-extra-space-in-link-script-tag

srsathish92 requested a review from engcom-Delta March 7, 2024 06:12

engcom-November self-assigned this May 21, 2024

Merge branch '2.4-develop' into cleanup/remove-extra-space-in-link-sc…

a2e969c

…ript-tag

m2-community-project bot added Progress: testing in progress and removed Progress: needs update labels May 21, 2024

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels May 21, 2024

Resolve static test failures

c03b74a

m2-community-project bot added Progress: accept and removed Progress: extended testing labels May 22, 2024

magento-devops-reposync-svc merged commit a6f9324 into magento:2.4-develop May 28, 2024

[View] Removed extra space in link and script tag #32919

[View] Removed extra space in link and script tag #32919

Uh oh!

Conversation

srsathish92 commented Apr 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Apr 30, 2021

Uh oh!

srsathish92 commented Apr 30, 2021

Uh oh!

magento-automated-testing bot commented Apr 30, 2021

Uh oh!

srsathish92 commented Apr 30, 2021

Uh oh!

Den4ik commented Apr 30, 2021

Uh oh!

magento-automated-testing bot commented Apr 30, 2021

Uh oh!

srsathish92 commented May 1, 2021

Uh oh!

magento-automated-testing bot commented May 1, 2021

Uh oh!

srsathish92 commented May 1, 2021

Uh oh!

magento-automated-testing bot commented May 1, 2021

Uh oh!

Den4ik left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented May 3, 2021

Uh oh!

Den4ik commented May 7, 2021

Uh oh!

engcom-Delta commented Feb 9, 2024

Uh oh!

engcom-Delta left a comment

Choose a reason for hiding this comment

Uh oh!

srsathish92 commented Mar 7, 2024

Uh oh!

engcom-November commented May 21, 2024

Uh oh!

engcom-November commented May 21, 2024

Uh oh!

engcom-November commented May 21, 2024

Uh oh!

engcom-November commented May 21, 2024

Uh oh!

engcom-November commented May 22, 2024

Uh oh!

engcom-November commented May 22, 2024

Uh oh!

engcom-November commented May 22, 2024

Uh oh!

Uh oh!

srsathish92 commented Apr 30, 2021 •

edited

Loading