Skip to content

Replace repetitive actions with Action Groups in AdminCreateVirtualProductFillingRequiredFieldsOnlyTest #32477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Replace repetitive actions with Action Groups in AdminCreateVirtualProductFillingRequiredFieldsOnlyTest #32477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 39 additions & 16 deletions ...Magento/Catalog/Test/Mftf/Test/AdminCreateVirtualProductFillingRequiredFieldsOnlyTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,31 +25,54 @@
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
</after>

<actionGroup ref="AdminProductCatalogPageOpenActionGroup" stepKey="openProductCatalogPage"/>
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility" stepKey="clickAddProductToggle"/>
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility" stepKey="waitForProductToggleToSelectProduct"/>
<actionGroup ref="AdminClickAddProductToggleAndSelectProductTypeActionGroup" stepKey="clickVirtualProduct">
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
stepKey="openProductCatalogPage"/>
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
stepKey="clickAddProductToggle"/>
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
stepKey="waitForProductToggleToSelectProduct"/>
<actionGroup ref="AdminOpenNewProductFormPageActionGroup" stepKey="clickVirtualProduct">
<argument name="productType" value="virtual"/>
</actionGroup>

<!-- Create virtual product with required fields only -->
<fillField selector="{{AdminProductFormSection.productName}}" userInput="{{virtualProductWithRequiredFields.name}}" stepKey="fillProductName"/>
<fillField selector="{{AdminProductFormSection.productSku}}" userInput="{{virtualProductWithRequiredFields.sku}}" stepKey="fillProductSku"/>
<fillField selector="{{AdminProductFormSection.productPrice}}" userInput="{{virtualProductWithRequiredFields.price}}" stepKey="fillProductPrice"/>
<actionGroup ref="FillProductNameAndSkuInProductFormActionGroup" stepKey="fillProductName">
<argument name="product" value="virtualProductWithRequiredFields"/>
</actionGroup>
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
stepKey="fillProductSku"/>
<actionGroup ref="AdminFillProductPriceFieldAndPressEnterOnProductEditPageActionGroup" stepKey="fillProductPrice">
<argument name="price" value="{{virtualProductWithRequiredFields.price}}"/>
</actionGroup>
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickSaveButton"/>

<!-- Verify we see success message -->
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertVirtualProductSuccessMessage"/>
<actionGroup ref="AssertMessageInAdminPanelActionGroup" stepKey="seeAssertVirtualProductSuccessMessage">
<argument name="message" value="You saved the product."/>
</actionGroup>

<!-- Verify we see created virtual product(from the above step) on the product grid page -->
<actionGroup ref="AdminProductCatalogPageOpenActionGroup" stepKey="openProductCatalogPage1"/>
<conditionalClick selector="{{AdminProductGridFilterSection.clearAll}}" dependentSelector="{{AdminProductGridFilterSection.clearAll}}" visible="true" stepKey="clickSelector"/>
<click selector="{{AdminProductGridFilterSection.filters}}" stepKey="clickFilter"/>
<fillField selector="{{AdminProductGridFilterSection.nameFilter}}" userInput="{{virtualProductWithRequiredFields.name}}" stepKey="fillProductName1"/>
<fillField selector="{{AdminProductGridFilterSection.skuFilter}}" userInput="{{virtualProductWithRequiredFields.sku}}" stepKey="fillVirtualProductSku"/>
<click selector="{{AdminProductGridFilterSection.applyFilters}}" stepKey="clickSearch2"/>
<waitForPageLoad stepKey="waitForProductSearch"/>
<seeInField selector="{{AdminProductGridFilterSection.nameFilter}}" userInput="{{virtualProductWithRequiredFields.name}}" stepKey="seeVirtualProductName"/>
<seeInField selector="{{AdminProductGridFilterSection.skuFilter}}" userInput="{{virtualProductWithRequiredFields.sku}}" stepKey="seeVirtualProductSku"/>
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
stepKey="clickSelector"/>
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
stepKey="clickFilter"/>
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
stepKey="fillProductName1"/>
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
stepKey="fillVirtualProductSku"/>
<actionGroup ref="FilterProductGridBySkuAndNameActionGroup" stepKey="clickSearch2">
<argument name="product" value="virtualProductWithRequiredFields"/>
</actionGroup>
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
stepKey="waitForProductSearch"/>
<actionGroup ref="AssertAdminProductGridCellActionGroup" stepKey="seeVirtualProductName">
<argument name="column" value="Name"/>
<argument name="value" value="{{virtualProductWithRequiredFields.name}}"/>
</actionGroup>
<actionGroup ref="AssertAdminProductGridCellActionGroup" stepKey="seeVirtualProductSku">
<argument name="column" value="SKU"/>
<argument name="value" value="{{virtualProductWithRequiredFields.sku}}"/>
</actionGroup>
</test>
</tests>