-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Updated tedivm/jshrink dependency to PHP 8 compatible version #31800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated tedivm/jshrink dependency to PHP 8 compatible version #31800
Conversation
Hi @vlmed. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
0e6ca5f
to
5f52967
Compare
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vlmed thanks for the pull request! Can you please also update EE composer.json and lock files and link the EE pull request using the related PR section. That should fix static tests
@magento run all tests |
…e_tedivm_shrink_dependency_to_PHP8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @vlmed
Please, fix conflicts for the composer.lock and one of the lib modules composer.json. Looks like this is a result of the latest PHP8 dev branch merge.
…m_shrink_dependency_to_PHP8
Hello @coderimus, @sivaschenko. Thanks for review. Conflicts have already been resolved. |
@magento run all tests |
… into update_tedivm_shrink_dependency_to_PHP8
@magento run all tests |
@magento run WebAPI Tests,Functional Tests CE |
Hi @vlmed, thank you for your contribution! |
Description (*)
Update
tedivm/jshrink
dependency version from "~1.3.0" to "~1.4.0"Related Pull Requests
https://github.com/magento/partners-magento2ee/pull/457
Fixed Issues (if relevant)
Contribution checklist (*)