Skip to content

Magento_Rss: avoid using deprecated escape* methods from AbstractBlock #31728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Magento_Rss: avoid using deprecated escape* methods from AbstractBlock #31728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions app/code/Magento/Rss/view/frontend/templates/feeds.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,28 +4,31 @@
* See COPYING.txt for license details.
*/

/** @var \Magento\Rss\Block\Feeds $block */
/**
* @var \Magento\Rss\Block\Feeds $block
* @var \Magento\Framework\Escaper $escaper
*/

?>
<table class="data table rss">
<caption class="table-caption"><?= $block->escapeHtml(__('Feed')) ?></caption>
<caption class="table-caption"><?= $escaper->escapeHtml(__('Feed')) ?></caption>
<tbody>
<th colspan="2" scope="col"><?= $block->escapeHtml(__('Miscellaneous Feeds')) ?></th>
<th colspan="2" scope="col"><?= $escaper->escapeHtml(__('Miscellaneous Feeds')) ?></th>
<?php foreach ($block->getFeeds() as $feed) : ?>
<?php if (!isset($feed['group'])) : ?>
<tr>
<td class="col feed"><?= $block->escapeHtml($feed['label']) ?></td>
<td class="col feed"><?= $escaper->escapeHtml($feed['label']) ?></td>
<td class="col action">
<a href="<?= $block->escapeUrl($feed['link']) ?>" class="action get"><span><?= $block->escapeHtml(__('Get Feed')) ?></span></a>
<a href="<?= $escaper->escapeUrl($feed['link']) ?>" class="action get"><span><?= $escaper->escapeHtml(__('Get Feed')) ?></span></a>
</td>
</tr>
<?php else : ?>
<th colspan="2" scope="col"><?= $block->escapeHtml($feed['group']) ?></th>
<th colspan="2" scope="col"><?= $escaper->escapeHtml($feed['group']) ?></th>
<?php foreach ($feed['feeds'] as $item) :?>
<tr>
<td class="col feed"><?= $block->escapeHtml($item['label']) ?></td>
<td class="col feed"><?= $escaper->escapeHtml($item['label']) ?></td>
<td class="col action">
<a href="<?= $block->escapeUrl($item['link']) ?>" class="action get"><span><?= $block->escapeHtml(__('Get Feed')) ?></span></a>
<a href="<?= $escaper->escapeUrl($item['link']) ?>" class="action get"><span><?= $escaper->escapeHtml(__('Get Feed')) ?></span></a>
</td>
</tr>
<?php endforeach; ?>
Expand Down