Skip to content

Magento_MediaStorage: avoid using deprecated escape* methods from Abs… #31699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Magento_MediaStorage: avoid using deprecated escape* methods from Abs… #31699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ...ediaStorage/view/adminhtml/templates/system/config/system/storage/media/synchronize.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

/**
* @var $block \Magento\MediaStorage\Block\System\Config\System\Storage\Media\Synchronize
* @var \Magento\Framework\Escaper $escaper
* @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer
*/
?>
Expand Down Expand Up @@ -39,8 +40,8 @@ require([
$('system_media_storage_configuration_media_database').value
);

addAllowedStorage({$block->escapeJs($syncStorageParams['storage_type'])},
'{$block->escapeJs($syncStorageParams['connection_name'])}');
addAllowedStorage({$escaper->escapeJs($syncStorageParams['storage_type'])},
'{$escaper->escapeJs($syncStorageParams['connection_name'])}');

defaultValues = [];
defaultValues['system_media_storage_configuration_media_storage'] =
Expand Down Expand Up @@ -100,7 +101,7 @@ require([
}

var checkStatus = function() {
u = new Ajax.PeriodicalUpdater('', '{$block->escapeJs($block->getAjaxStatusUpdateUrl())}', {
u = new Ajax.PeriodicalUpdater('', '{$escaper->escapeJs($block->getAjaxStatusUpdateUrl())}', {
method: 'get',
frequency: 5,
loaderArea: false,
Expand Down Expand Up @@ -162,7 +163,7 @@ require([
connection: $('system_media_storage_configuration_media_database').value
};

new Ajax.Request('{$block->escapeJs($block->getAjaxSyncUrl())}', {
new Ajax.Request('{$escaper->escapeJs($block->getAjaxSyncUrl())}', {
parameters: params,
loaderArea: false,
asynchronous: true
Expand All @@ -188,7 +189,7 @@ script;

<?= $block->getButtonHtml() ?>
<span class="sync-indicator no-display" id="sync_span">
<img alt="Synchronize" src="<?= $block->escapeUrl($block->getViewFileUrl('images/process_spinner.gif')) ?>"/>
<img alt="Synchronize" src="<?= $escaper->escapeUrl($block->getViewFileUrl('images/process_spinner.gif')) ?>"/>
<span id="sync_message_span"></span>
</span>
<?= /* @noEscape */ $secureRenderer->renderStyleAsTag("margin:0 5px", '#sync_span img') ?>
Expand Down