Updated sebastian/phpcpd, phpunit/phpunit and laminas/laminas-server dependency for php8 update #31383

konarshankar07 · 2020-12-22T03:55:46Z

Description (*)

This PR will update the packages related to php8 compatibility

Fixed Issues (if relevant)

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…o#31345 magento#31344 magento#31343 magento#31342 magento#31341 magento#31340

m2-assistant · 2020-12-22T03:55:49Z

Hi @konarshankar07. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me php8-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

sivaschenko · 2021-01-04T10:26:47Z

@magento run all tests

coderimus

Hello @konarshankar07
Thank you for the work you have done in the scope of the PHP8 compatibility. 👍

Please, take a look at my comment about the minimum-stability.

coderimus · 2021-01-04T10:35:46Z

composer.json

@@ -385,5 +385,6 @@
            "Magento\\PhpStan\\": "dev/tests/static/framework/Magento/PhpStan/"
        }
    },
-    "prefer-stable": true
+    "prefer-stable": true,
+    "minimum-stability": "dev"


We must avoid using the dev as a minimum-stability. Please, change.

sivaschenko

Thanks for the pull request @konarshankar07 ! Can you please take a look at my comment

sivaschenko · 2021-01-04T11:04:23Z

composer.json

@@ -385,5 +385,6 @@
            "Magento\\PhpStan\\": "dev/tests/static/framework/Magento/PhpStan/"
        }
    },
-    "prefer-stable": true
+    "prefer-stable": true,
+    "minimum-stability": "dev"


I don't think the minimum stability should be dropped to dev. Is that required for some reason?

sivaschenko · 2021-01-04T15:17:03Z

@magento run all tests

konarshankar07 · 2021-01-04T16:44:02Z

Hello @sivaschenko @coderimus
Minimum stability is set to dev for the elasticsearch/elasticsearch update
Thanks

sivaschenko · 2021-01-04T17:22:37Z

@konarshankar07 I see, elasticsearch 7.11 is not yet published. Let's update the elasticsearch version later, when 7.11 will be available on packagist https://packagist.org/packages/elasticsearch/elasticsearch to keep all the dependencies stable.

konarshankar07 · 2021-01-05T04:41:08Z

@sivaschenko
Should we downgrade the elasticsearch for now or we need to wait for the release?

coderimus · 2021-01-05T06:52:23Z

@konarshankar07 in our case we have to not to have any dev stability packages and taken into account the next 2 aspects we need to downgrade it to the stable one:

7.11 release will not be soon and, possibly, during this time we will have other packages updated and, maybe, new conflicts, so it is better to have PHP8 compatible system now :) to unblock Magento 3rd party vendors to upgrade their packages if needed.
I think that the upgrade of the ES should be another complex task because ES is one of the critical packages which is responsible for data. It will need not only to upgrade version but also revied from the security perspective.
cc @sivaschenko

konarshankar07 · 2021-01-05T07:17:22Z

@coderimus
Thanks for the response. What do you suggest to move forward with this PR?

sivaschenko

Hi @konarshankar07 , please see a summary of changes required for the PR to move forward

sivaschenko · 2021-01-05T13:32:55Z

composer.json

@@ -33,18 +33,18 @@
        "colinmollenhour/credis": "1.11.1",
        "colinmollenhour/php-redis-session-abstract": "~1.4.0",
        "composer/composer": "^1.9",
-        "elasticsearch/elasticsearch": "~7.7.0",
+        "elasticsearch/elasticsearch": "~7.11.0",


Let's revert the elasticsearch version change

sivaschenko · 2021-01-05T13:33:15Z

composer.json

@@ -385,5 +385,6 @@
            "Magento\\PhpStan\\": "dev/tests/static/framework/Magento/PhpStan/"
        }
    },
-    "prefer-stable": true
+    "prefer-stable": true,
+    "minimum-stability": "dev"


this line should be removed

konarshankar07 · 2021-01-06T04:52:18Z

@sivaschenko
Thanks for the suggestion and I have reverted the elasticsearch update and removed the minimum stability.

konarshankar07 · 2021-01-06T04:52:36Z

@magento run all tests

coderimus · 2021-01-06T07:58:04Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Sample Data Tests CE , Static Tests, Unit Tests, WebAPI Tests

coderimus · 2021-01-06T09:32:49Z

@sivaschenko @konarshankar07 I have things to discuss:

I think we have to have PHP 8 instead of PHP 7.4 on our test builds. And we have to modify the composer required section: "php": "~7.3.0||~7.4.0|| ~8.0.0",

I think we should raise a discussion about having the laminas/laminas-code 4.x.x in our project instead of the 3.x.x. From my perspective, having the 4.x.x is better because:

4.x.x will have support for all new PHP8 features
It has PHP 7.4 as minimum supported version
of course fixes and improvements according to the CHANGE.log
having major version is good for future releases

This 4.0.0 version has some BC breaks and I think that they will not affect us or if so we will fix them :)

What do you think?

konarshankar07 · 2021-01-06T10:22:07Z

Hello @coderimus
yes, I agree with you but it should be covered in different PR and its part of #31081 issue and I think @jamescowie is working on this update
For Ref:- #31269

coderimus · 2021-01-06T13:30:38Z

@konarshankar07 thank you for details and link PHP 8 upgrade issue 👍 Now I have a more clear vision of the whole process.

From my perspective, the PHP 8 version set to the required section of the composer.json should be done in the scope of this issue because without it we are not able to say that updated versions, Magento core code and 3rd party vendors included to the package are really compatible. Because here the PHP version is a conductor and dependencies are followers. Also, the laminas/laminas-code has a new version with fixes, updates for the PHP 8 which makes having 3.x.x version is not required, as for me.

I can suggest next:

set PHP 8 requirement to the composer.json
check result
update laminas/laminas-code to the 4.x.x (fix BIC things)
update all other libraries if not done in step 2

With this flow, I think, we will have PHP 8 compatibility upgrade consistently. Otherwise, we provide not the php8 dependency upgrade but the simple dependency upgrade :)

What do you think about this? @konarshankar07 @sivaschenko

sivaschenko · 2021-01-06T13:38:48Z

Hi @coderimus @konarshankar07

We will not be able to run tests on PHP 8 until all dependencies are updated. Let's do this step by step.
I think it would be better to update laminas components to the minimal version compatible with PHP 8 in the scope of PHP 8 compatibility project, to avoid additional work and BIC.

coderimus · 2021-01-06T13:45:53Z

Hi @sivaschenko @konarshankar07

@sivaschenko thank you for the update strategy explanation. Got your point and agreed with it. Let's proceed as you suggested.

sivaschenko · 2021-01-06T13:52:40Z

@konarshankar07 can you please check if the failed tests can be fixed.

I.e. it looks like lib/internal/Magento/Framework/composer.json should be updated as well to fix static tests

Also, can you please ensure composer.lock is updated only for the changed dependencies.

(run composer update specific package instead of general composer update)

konarshankar07 · 2021-01-07T05:34:02Z

@magento run all tests

konarshankar07 · 2021-01-10T13:51:39Z

@magento run all tests

konarshankar07 · 2021-01-19T06:12:31Z

@magento run all tests

coderimus · 2021-01-27T07:27:40Z

@magento run all tests

konarshankar07 · 2021-01-29T07:00:48Z

@magento run all tests

konarshankar07 · 2021-01-29T14:12:17Z

@magento run Static Tests

konarshankar07 · 2021-02-08T03:30:08Z

@magento run all tests

konarshankar07 · 2021-02-08T13:32:22Z

@magento run all tests

konarshankar07 · 2021-02-09T05:06:19Z

@magento run all tests

m2-assistant · 2021-02-17T06:42:21Z

Hi @konarshankar07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Updated dependency for php8 update magento#31347 magento#31346 magent…

2c4dd98

…o#31345 magento#31344 magento#31343 magento#31342 magento#31341 magento#31340

m2-community-project bot added the Progress: pending review label Dec 22, 2020

sidolov added the Project: PHP8 label Dec 23, 2020

coderimus self-assigned this Jan 4, 2021

coderimus self-requested a review January 4, 2021 10:23

m2-community-project bot added Progress: review and removed Progress: pending review labels Jan 4, 2021

coderimus suggested changes Jan 4, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Jan 4, 2021

sivaschenko requested changes Jan 4, 2021

View reviewed changes

m2-community-project bot assigned sivaschenko Jan 4, 2021

sivaschenko requested changes Jan 5, 2021

View reviewed changes

elasticsearch update reverted and also removed the minimum-stability

9ba236c

composer.json updated for magento/framework library

6d214c0

konarshankar07 marked this pull request as draft January 7, 2021 11:24

__invoke method implemented as per laminas v3

6be1aa1

laminas/laminas-servicemanager-di installed for testing purpose

54d12d0

konarshankar07 mentioned this pull request Jan 22, 2021

Update laminas/laminas-mvc dependency to PHP 8 compatible version #31783

Closed

konarshankar07 added 4 commits January 29, 2021 12:09

Reverted changes

08293ea

Merge branch 'upstream-php8-develop' into php8-dependency-updates

ef82c15

laminas/laminas-server updated

b1a20be

sebastian/phpcpd and phpunit upgraded

79e17be

konarshankar07 changed the title ~~Updated dependency for php8 update~~ Updated sebastian/phpcpd, phpunit/phpunit and laminas/laminas-server dependency for php8 update Jan 29, 2021

konarshankar07 added 2 commits February 8, 2021 08:56

Fixed merge conflict

8aff41a

Fixed static test

8641c0e

Fixed phpunit issue

ccc78c7

Fixed phpunit upgrade issues

f527c43

konarshankar07 closed this Feb 17, 2021

m2-community-project bot removed the Progress: needs update label Feb 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated sebastian/phpcpd, phpunit/phpunit and laminas/laminas-server dependency for php8 update #31383

Updated sebastian/phpcpd, phpunit/phpunit and laminas/laminas-server dependency for php8 update #31383

konarshankar07 commented Dec 22, 2020 •

edited

Loading

m2-assistant bot commented Dec 22, 2020

sivaschenko commented Jan 4, 2021

coderimus left a comment

coderimus Jan 4, 2021

sivaschenko left a comment

sivaschenko Jan 4, 2021

sivaschenko commented Jan 4, 2021

konarshankar07 commented Jan 4, 2021

sivaschenko commented Jan 4, 2021

konarshankar07 commented Jan 5, 2021

coderimus commented Jan 5, 2021

konarshankar07 commented Jan 5, 2021

sivaschenko left a comment •

edited

Loading

sivaschenko Jan 5, 2021

sivaschenko Jan 5, 2021

konarshankar07 commented Jan 6, 2021

konarshankar07 commented Jan 6, 2021

coderimus commented Jan 6, 2021

coderimus commented Jan 6, 2021

konarshankar07 commented Jan 6, 2021 •

edited

Loading

coderimus commented Jan 6, 2021 •

edited

Loading

sivaschenko commented Jan 6, 2021

coderimus commented Jan 6, 2021

sivaschenko commented Jan 6, 2021 •

edited

Loading

konarshankar07 commented Jan 7, 2021

konarshankar07 commented Jan 10, 2021

konarshankar07 commented Jan 19, 2021

coderimus commented Jan 27, 2021

konarshankar07 commented Jan 29, 2021

konarshankar07 commented Jan 29, 2021

konarshankar07 commented Feb 8, 2021

konarshankar07 commented Feb 8, 2021

konarshankar07 commented Feb 9, 2021

m2-assistant bot commented Feb 17, 2021

Updated sebastian/phpcpd, phpunit/phpunit and laminas/laminas-server dependency for php8 update #31383

Updated sebastian/phpcpd, phpunit/phpunit and laminas/laminas-server dependency for php8 update #31383

Conversation

konarshankar07 commented Dec 22, 2020 • edited Loading

Description (*)

Fixed Issues (if relevant)

Contribution checklist (*)

m2-assistant bot commented Dec 22, 2020

sivaschenko commented Jan 4, 2021

coderimus left a comment

Choose a reason for hiding this comment

coderimus Jan 4, 2021

Choose a reason for hiding this comment

sivaschenko left a comment

Choose a reason for hiding this comment

sivaschenko Jan 4, 2021

Choose a reason for hiding this comment

sivaschenko commented Jan 4, 2021

konarshankar07 commented Jan 4, 2021

sivaschenko commented Jan 4, 2021

konarshankar07 commented Jan 5, 2021

coderimus commented Jan 5, 2021

konarshankar07 commented Jan 5, 2021

sivaschenko left a comment • edited Loading

Choose a reason for hiding this comment

sivaschenko Jan 5, 2021

Choose a reason for hiding this comment

sivaschenko Jan 5, 2021

Choose a reason for hiding this comment

konarshankar07 commented Jan 6, 2021

konarshankar07 commented Jan 6, 2021

coderimus commented Jan 6, 2021

coderimus commented Jan 6, 2021

konarshankar07 commented Jan 6, 2021 • edited Loading

coderimus commented Jan 6, 2021 • edited Loading

sivaschenko commented Jan 6, 2021

coderimus commented Jan 6, 2021

sivaschenko commented Jan 6, 2021 • edited Loading

konarshankar07 commented Jan 7, 2021

konarshankar07 commented Jan 10, 2021

konarshankar07 commented Jan 19, 2021

coderimus commented Jan 27, 2021

konarshankar07 commented Jan 29, 2021

konarshankar07 commented Jan 29, 2021

konarshankar07 commented Feb 8, 2021

konarshankar07 commented Feb 8, 2021

konarshankar07 commented Feb 9, 2021

m2-assistant bot commented Feb 17, 2021

konarshankar07 commented Dec 22, 2020 •

edited

Loading

sivaschenko left a comment •

edited

Loading

konarshankar07 commented Jan 6, 2021 •

edited

Loading

coderimus commented Jan 6, 2021 •

edited

Loading

sivaschenko commented Jan 6, 2021 •

edited

Loading