Skip to content

Update friendsofphp/php-cs-fixer dependency to PHP 8 Compatible version #31343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sivaschenko opened this issue Dec 18, 2020 · 4 comments · Fixed by #31772
Closed

Update friendsofphp/php-cs-fixer dependency to PHP 8 Compatible version #31343

sivaschenko opened this issue Dec 18, 2020 · 4 comments · Fixed by #31772
Assignees
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Progress: done Project: PHP8

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Dec 18, 2020

Description (*)

Update friendsofphp/php-cs-fixer dependency version to "~2.18.0"

Expected behavior (*)

Benefits

Additional information

@m2-assistant
Copy link

m2-assistant bot commented Dec 18, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@hostep
Copy link
Contributor

hostep commented Jan 20, 2021

Version 2.18.0 was released a couple of days ago, does it make sense to directly move to that version?

It contains one more fix needed for php 8 I think?

@sivaschenko
Copy link
Member Author

@hostep yes, thank you! Updated. cc @konarshankar07

@sivaschenko sivaschenko changed the title Update friendsofphp/php-cs-fixer dependency version to "~2.17.0" Update friendsofphp/php-cs-fixer dependency to PHP 8 Compatible version Jan 21, 2021
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Mar 12, 2021
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, @konarshankar07.

Thank you for your report and collaboration!

The related internal Jira ticket MC-39653 was closed as Complete.

The fix will be available with the upcoming 2.4.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Progress: done Project: PHP8
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants