Allowed php 8 compatible phpstan version

[sivaschenko]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Update phpstan/phpstan dependency to PHP 8 compatible version #31176

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @sivaschenko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me php8-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[sivaschenko]

@magento run all tests

[sivaschenko]

@magento run Sample Data Tests CE,Sample Data Tests EE,Sample Data Tests B2B

[m2-assistant]

Hi @sivaschenko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me php8-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[sivaschenko]

@magento run Database Compare,Static Tests

[hostep]

This conflicts with: #30581

@sivaschenko: why the upper bound? Please allow all 0.12.* versions...

Also: a lot of newer releases of phpstan at this moment contain fixes for PHP 8, so why limit yourself to max 0.12.54?

[ihor-sviziev]

Hi @sivaschenko,
This is duplicate of #30581
That was approved in October, but still didn’t get any attention. Can we close this one and move forward original one?
Also not clear why can't we use ^0.12.3 as suggested in original PR?

[sivaschenko]

@hostep @ihor-sviziev thanks for the link to the duplicate PR.

I've basically used this PR to test the PHP 8 project boards and builds on php8-develop branch that I have been preparing.

Closing it now.

We are going to provide more information on PHP 8 compatibility for Magento soon. Meanwhile can you please mark the PRs/issues related to PHP 8 with "Project: PHP8" label, also all related PRs should be targeting php8-develop branch (it's based on 2.4-develop).

The boards for PHP 8 Compatibility project:
Backlog: https://github.com/magento/magento2/projects/31
PRs: https://github.com/magento/magento2/projects/32

[m2-assistant]

Hi @sivaschenko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.