Invalid combination of tabs and spaces in phpstan.neon

[DmitryFurs]

Description (*)

The phpstan.neon file contains both spaces and tabs for different lines. But one line contains both characters. In our case, this line is a comment, and it is ignored during parsing, but this is denied by nette/neon parser. In addition, for code consistency, it must be brought to a common style.

Related Pull Requests

4e045c7#diff-b47a177d03a63c60ce971880ec7d61c2ba5bb7126f3ec0357f97059e4db4f859
19b636e#diff-b47a177d03a63c60ce971880ec7d61c2ba5bb7126f3ec0357f97059e4db4f859

Manual testing scenarios (*)

1. Open phpstan.neon file in PhpStorm with NEON support plugin
2. It is highlighted with errors
   

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Invalid combination of tabs and spaces in phpstan.neon #31239: Invalid combination of tabs and spaces in phpstan.neon

[m2-assistant]

Hi @DmitryFurs. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

good catch.
Can we add it to the .editorconfig file?

[ihor-sviziev]

@magento run Static Tests

[DmitryFurs]

@ihor-sviziev it looks like this is already covered by the global rules

[*]
...
indent_size = 4
indent_style = space
...

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

@magento run WebAPI Tests

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8527 has been created to process this Pull Request

[engcom-Alfa]

@magento create issue

[engcom-Alfa]

✔️ QA Passed

Before: ✖️ Invalid combination of tabs and spaces

After: ✔️

[m2-assistant]

Hi @DmitryFurs, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.