Fix #30724 - Customer Account Edit controller action enforces Page Title to "Account Information" #31157

Bartlomiejsz · 2020-12-03T16:38:09Z

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes Customer Account Edit controller action enforces Page Title to "Account Information" #30724

Manual testing scenarios (*)

Please check fixed issue for testing scenario

Questions or comments

I don't think any tests would be applicable here

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…Page Title to "Account Information"

m2-assistant · 2020-12-03T16:38:12Z

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Bartlomiejsz · 2020-12-03T16:38:34Z

@magento run all tests

Bartlomiejsz · 2020-12-04T08:30:39Z

@magento run Functional Tests B2B, Functional Tests CE, Integration Tests

rogyar · 2020-12-04T08:47:03Z

@magento give me test instance

magento-deployment-service · 2020-12-04T08:47:05Z

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2020-12-04T08:51:37Z

Hi @rogyar, here is your Magento Instance: https://b720df3bab2a2c1752044f2074534d7b.instances.magento-community.engineering
Admin access: https://b720df3bab2a2c1752044f2074534d7b.instances.magento-community.engineering/admin_b053
Login: 1ad6a758
Password: a4b4a1ccd733

rogyar · 2020-12-04T08:54:47Z

For QA. I believe we don't need to cover this change with another heavy auto-test just for checking the page title.
Thanks.

magento-engcom-team · 2020-12-06T15:55:40Z

Hi @rogyar, thank you for the review.
ENGCOM-8524 has been created to process this Pull Request

engcom-Alfa · 2020-12-07T08:43:54Z

✔️ QA Passed

Manual testing scenario:

Change the page title in view/frontend/layout/customer_account_edit.xml file of a module

    <head>
        <title>Custom Account Information</title>
    </head>

Go to Storefront -> My Account -> Account Information

Before: ✖️ The title wasn't changed

After: ✔️ The title was changed

✔️ The translation of the title was also checked and everything works as expected.

engcom-Hotel · 2020-12-14T18:03:21Z

@magento run Functional Tests B2B, Integration Tests

engcom-Hotel · 2020-12-14T20:27:14Z

@magento run Functional Tests B2B

engcom-Hotel · 2020-12-15T08:02:56Z

@magento run Functional Tests B2B

…orces Page Title to "Account Information" #31157

m2-assistant · 2020-12-24T06:26:59Z

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Fix magento#30724 - Customer Account Edit controller action enforces …

92e9422

…Page Title to "Account Information"

m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Dec 3, 2020

magento-engcom-team added Area: Frontend Component: Customer Release Line: 2.4 Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner labels Dec 3, 2020

m2-community-project bot added the Progress: pending review label Dec 3, 2020

rogyar self-assigned this Dec 4, 2020

m2-community-project bot added Progress: review and removed Progress: pending review labels Dec 4, 2020

rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Dec 4, 2020

rogyar added the Award: bug fix label Dec 4, 2020

rogyar approved these changes Dec 6, 2020

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Dec 6, 2020

engcom-Alfa self-assigned this Dec 7, 2020

m2-community-project bot added Progress: testing in progress Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. and removed Progress: ready for testing labels Dec 7, 2020

engcom-Alfa added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Dec 7, 2020

m2-community-project bot added Progress: ready for testing and removed Progress: testing in progress labels Dec 7, 2020

engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Dec 7, 2020

m2-community-project bot added Progress: testing in progress Progress: extended testing and removed Progress: ready for testing Progress: testing in progress labels Dec 7, 2020

engcom-Hotel self-assigned this Dec 14, 2020

m2-community-project bot added Progress: ready for testing and removed Progress: extended testing labels Dec 14, 2020

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels Dec 15, 2020

sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P3 May be fixed according to the position in the backlog. labels Dec 22, 2020

m2-community-project bot added Progress: ready for testing Progress: accept and removed Progress: accept Progress: ready for testing labels Dec 22, 2020

magento-engcom-team mentioned this pull request Dec 24, 2020

Customer Account Edit controller action enforces Page Title to "Account Information" #30724

Closed

5 tasks

m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Dec 24, 2020

magento-engcom-team pushed a commit that referenced this pull request Dec 24, 2020

ENGCOM-8524: Fix #30724 - Customer Account Edit controller action enf…

64df7a3

…orces Page Title to "Account Information" #31157

magento-engcom-team merged commit ed277dc into magento:2.4-develop Dec 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix #30724 - Customer Account Edit controller action enforces Page Title to "Account Information" #31157

Fix #30724 - Customer Account Edit controller action enforces Page Title to "Account Information" #31157

Uh oh!

Bartlomiejsz commented Dec 3, 2020 •

edited

Loading

Uh oh!

m2-assistant bot commented Dec 3, 2020

Uh oh!

Bartlomiejsz commented Dec 3, 2020

Uh oh!

Bartlomiejsz commented Dec 4, 2020

Uh oh!

rogyar commented Dec 4, 2020

Uh oh!

magento-deployment-service bot commented Dec 4, 2020

Uh oh!

magento-deployment-service bot commented Dec 4, 2020

Uh oh!

rogyar commented Dec 4, 2020

Uh oh!

magento-engcom-team commented Dec 6, 2020

Uh oh!

engcom-Alfa commented Dec 7, 2020

Uh oh!

engcom-Hotel commented Dec 14, 2020

Uh oh!

engcom-Hotel commented Dec 14, 2020

Uh oh!

engcom-Hotel commented Dec 15, 2020

Uh oh!

m2-assistant bot commented Dec 24, 2020

Uh oh!

Uh oh!

Fix #30724 - Customer Account Edit controller action enforces Page Title to "Account Information" #31157

Fix #30724 - Customer Account Edit controller action enforces Page Title to "Account Information" #31157

Uh oh!

Conversation

Bartlomiejsz commented Dec 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Dec 3, 2020

Uh oh!

Bartlomiejsz commented Dec 3, 2020

Uh oh!

Bartlomiejsz commented Dec 4, 2020

Uh oh!

rogyar commented Dec 4, 2020

Uh oh!

magento-deployment-service bot commented Dec 4, 2020

Uh oh!

magento-deployment-service bot commented Dec 4, 2020

Uh oh!

rogyar commented Dec 4, 2020

Uh oh!

magento-engcom-team commented Dec 6, 2020

Uh oh!

engcom-Alfa commented Dec 7, 2020

Uh oh!

engcom-Hotel commented Dec 14, 2020

Uh oh!

engcom-Hotel commented Dec 14, 2020

Uh oh!

engcom-Hotel commented Dec 15, 2020

Uh oh!

m2-assistant bot commented Dec 24, 2020

Uh oh!

Uh oh!

Bartlomiejsz commented Dec 3, 2020 •

edited

Loading