Fix minisearch not appear when disable suggestions search

[mrtuvn]

Description (*)

Previously when owner shop disable suggestions search in backend config when user try search in mobile screen. Mini search will not active. User will not able to search thing

Use declarative syntax data-mage-init for improve performance instead script tag x-magento-init

Preconditions (*)

Magento 2.4-develop
Php 7.4

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes mini search field head does not appear if suggestions and recommendations are disabled. Luma Theme and mobile navigation. #30584

Manual testing scenarios (*)

1. Go to admin
2. Catalog > Catalog Search
3. Enable Search Suggestions Change to No
4. View storefront in real device mobile screen or resize browser screen
5. Click on search icon to see problem

Expected result (*)

Appear input form search (form minisearch)

Actual result (*)

✖️ Nothing happens

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[rogyar]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @rogyar, here is your Magento Instance: https://0fa44faba34fd3fe80d56a0c306fc62b-2-4-develop.instances.magento-community.engineering
Admin access: https://0fa44faba34fd3fe80d56a0c306fc62b-2-4-develop.instances.magento-community.engineering/admin_dee1
Login: 2892071c
Password: 9972ce355074

[rogyar]

@magento Functional Tests B2B, Functional Tests CE, Functional Tests EE

[rogyar]

Hi @mrtuvn, great job! Do you think we can cover this fix with auto-tests somehow?

[mrtuvn]

Sure let's cover it with some tests

[mrtuvn]

@rostyslav-hymon Can you let me know issue related with your change previously ? Why need to wrap quickSearch component initializing with php tag for check suggestions search enable ?
de9318d
CC: @rogyar

[rostyslav-hymon]

@rostyslav-hymon Can you let me know issue related with your change previously ? Why need to wrap quickSearch component initializing with php tag for check suggestions search enable ?
de9318d
CC: @rogyar

Hi @mrtuvn . My change resolved the issue where disabling "Search Suggestions" did not have an effect on "Quick Search" behavior. It looks like your code solves this problem more correctly.

[mrtuvn]

@engcom-Charlie @engcom-Bravo @engcom-Alfa What test type should i start for such case ? MFTF

[engcom-Charlie]

@mrtuvn yes, via MFTF.
Thank you.

[mrtuvn]

Can you help with coverage test by mftf
I'm not sure how to setup turn off search suggest and check availability input minisearch in below screen 768px by mftf

[mrtuvn]

@magento run all tests

[engcom-Charlie]

@magento run all tests

[mrtuvn]

Hi guys any ideas why Unit tests fails ? But all green when view reports

[mrtuvn]

@magento run Functional Tests B2B

[mrtuvn]

@magento run Functional Tests B2B

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-8464 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed
The result is the same as in #30634 (comment)

[m2-assistant]

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.