Skip to content

add --no-tablespaces parameters to mysqldump #30502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2020

Conversation

jonashrem
Copy link
Contributor

@jonashrem jonashrem commented Oct 15, 2020

Description (*)

adds --no-tablespaces to all occurrences of mysqldump. With this PR integration tests can run without the PROCESS privilege which is required since MySQL 5.7.31 / 8.0.21 to run mysqldump by default. See also https://dev.mysql.com/doc/relnotes/mysql/5.7/en/news-5-7-31.html#mysqld-5-7-31-security or https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-21.html for details

Related Pull Requests

/

Fixed Issues (if relevant)

/

Manual testing scenarios (*)

this only affects the integration tests.

With this PR integration tests can run without the PROCESS privilege which is required since MySQL 5.7.31 to run mysqldump by default.

Questions or comments

/

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] add --no-tablespaces parameters to mysqldump #30566: add --no-tablespaces parameters to mysqldump

@m2-assistant
Copy link

m2-assistant bot commented Oct 15, 2020

Hi @jonashrem. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@jonashrem
Copy link
Contributor Author

@magento run all tests

add missing colon
@jonashrem
Copy link
Contributor Author

@magento run all tests

@jonashrem
Copy link
Contributor Author

@magento run Functional Tests EE

@jonashrem
Copy link
Contributor Author

@magento run Integration Tests

@ihor-sviziev ihor-sviziev self-assigned this Oct 16, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage labels Oct 16, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8349 has been created to process this Pull Request

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Oct 19, 2020
@engcom-Delta engcom-Delta self-assigned this Oct 20, 2020
@engcom-Delta
Copy link
Contributor

engcom-Delta commented Oct 20, 2020

Note: QA not applicable

@engcom-Delta
Copy link
Contributor

Note: Automation tests are passed

@engcom-Delta engcom-Delta added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Oct 20, 2020
@engcom-Alfa
Copy link
Contributor

@magento create issue

@engcom-Delta engcom-Delta removed the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Oct 20, 2020
@magento-engcom-team magento-engcom-team merged commit 438710b into magento:2.4-develop Oct 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 24, 2020

Hi @jonashrem, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: Crontab Event: MageCONF CD 2020 Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Issue] add --no-tablespaces parameters to mysqldump
6 participants