-
Notifications
You must be signed in to change notification settings - Fork 9.4k
add --no-tablespaces parameters to mysqldump #30502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --no-tablespaces parameters to mysqldump #30502
Conversation
Hi @jonashrem. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
add missing colon
@magento run all tests |
@magento run Functional Tests EE |
@magento run Integration Tests |
Hi @ihor-sviziev, thank you for the review. |
Note: QA not applicable |
Note: Automation tests are passed |
@magento create issue |
Hi @jonashrem, thank you for your contribution! |
Description (*)
adds --no-tablespaces to all occurrences of mysqldump. With this PR integration tests can run without the PROCESS privilege which is required since MySQL 5.7.31 / 8.0.21 to run mysqldump by default. See also https://dev.mysql.com/doc/relnotes/mysql/5.7/en/news-5-7-31.html#mysqld-5-7-31-security or https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-21.html for details
Related Pull Requests
/
Fixed Issues (if relevant)
/
Manual testing scenarios (*)
this only affects the integration tests.
With this PR integration tests can run without the PROCESS privilege which is required since MySQL 5.7.31 to run mysqldump by default.
Questions or comments
/
Contribution checklist (*)
Resolved issues: