Skip to content

fix(supported-version): pin-back MySQL to breaking change for tests #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2022

Conversation

damienwebdev
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

On older versions of MySQL, the PROCESS privilege was not required. This was changed as described here: magento/magento2#30502.

Fixes: graycoreio/magento2-graphql-introspection-cache#6

What is the new behavior?

We pin back to older MySQL versions on older versions of Magento.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@damienwebdev damienwebdev force-pushed the fixup_mysql_versions_for_tests branch from 4d9e305 to c63232f Compare August 24, 2022 20:55
@damienwebdev
Copy link
Member Author

This error is actually in v2.4.0 surprisingly.

Idk wtf to do about it.

dotmailer/dotmailer-magento2-extension#566

@damienwebdev damienwebdev force-pushed the fixup_mysql_versions_for_tests branch from 5859b2e to 64c57d9 Compare August 25, 2022 20:15
@damienwebdev damienwebdev force-pushed the fixup_mysql_versions_for_tests branch from 64c57d9 to b4e7831 Compare August 25, 2022 20:16
@damienwebdev damienwebdev merged commit b4e7831 into main Aug 25, 2022
@damienwebdev damienwebdev deleted the fixup_mysql_versions_for_tests branch October 12, 2022 16:26
@gray-bot gray-bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant