Fix Issues 29213

[sarron93]

Description (*)

If use Magento\Backend\Block\Widget\Grid\Column\Filter\Price::getCondition method and Magento\Backend\Block\Widget\Grid\Column\Filter\Price::getValue() return array with indexes 'from' or 'to' string data, then PHP throw notice exception and Magento break apply filter, redirect to some page

Fixed Issues (if relevant)

1. Fixes Price Filter Into Grid not working for specific data #29213

Manual testing scenarios (*)

1. Create Grid Block with deprecated functionality extended class Magento\Backend\Block\Widget\Grid\Extended
2. Add column type price $this->addColumn( 'total_price', [ 'header' => __('Total Price'), 'index' => 'total_price', 'type' => 'price', 'currency_code' => (string)$this->_scopeConfig ->getValue(Currency::XML_PATH_CURRENCY_BASE), ] );
3. Apply a filter on this field. Example: '123a'
4. Apply filter price to 123 cost

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @sarron93. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[sarron93]

@magento run all tests

[rogyar]

Hi @sarron93. Thank you for your collaboration, makes sense to me. According to the definition of done all changes should be covered by autotests. Could I kindly ask you to create a simple unit test that will test the case with passing values like "123a"?

Thank you!

[sarron93]

Hello @rogyar, class Magento\Backend\Block\Widget\Grid\Column\Filter\Price for some reason it is not covered by any tests, should I completely cover it with tests?

[rogyar]

Hi @sarron93. That's a good question. I would say, you may if you wish to 😎
But it's not necessary to cover all the cases, only the change provided by you. So you may create a new test and cover only the corresponding method.

Thank you.

[sarron93]

Hello @rogyar, i'm created unit test for getCondition method

[sarron93]

@magento run all tests

[rogyar]

Good job! Please, check my minor recommendations. Also, please, check the failing static tests.
I will re-run the integration tests to double-check they are not related to the current change.

[rogyar]

@magento run Integration Tests

[sarron93]

@magento run Static Tests

[sarron93]

@magento run Integration Tests

[sarron93]

Hello @rogyar, integration and static tests complete after my changes

[rogyar]

@magento run all tests

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7962 has been created to process this Pull Request

[engcom-Kilo]

Test passed.
Tested with custom column (Sale Price) on Category, Products in Category.

Before:
If set value like 10a - will redirect to /admin_nkc1ww/catalog/ and in log added Exception.

After:
All variations of values for filter works correctly and returned result.

[m2-assistant]

Hi @sarron93, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.