Skip to content

Conversation

kamzata
Copy link

@kamzata kamzata commented Apr 17, 2020

It resolves

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Magento Store Switch - 2 store views, 2 domains. "The store that was requested wasn't found. Verify the store and try again." #27540 Store switch doesn't work correctly.

Manual testing scenarios (*)

  1. Tested on Magento CE 2.3.4

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 17, 2020

Hi @kamzata. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 14, 2020
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Aug 18, 2020

Seems like this PR just reverts changes from #15961, so it re-adds another issue

Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamzata initial fix was made to resolve the bug mentioned in #15961. Looks like it will start reproducing after your fix. Could you please take a look? Most likely we need to find a better solution to fix both bugs.

@kamzata
Copy link
Author

kamzata commented Aug 25, 2020

I cannot check anymore... now I'm running 2.4.0 and it works out of the box.

@ihor-sviziev
Copy link
Contributor

Thank you ! In this caseI’m closing this PR

@m2-assistant
Copy link

m2-assistant bot commented Aug 26, 2020

Hi @kamzata, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Store Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: needs update Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Magento Store Switch - 2 store views, 2 domains. "The store that was requested wasn't found. Verify the store and try again."
5 participants