Fixed creating shipping labels in part-shipment #27672

NikolasSumrak · 2020-04-09T10:33:30Z

Fixed creating package when we ship not all items

Description (*)

When we use sources, we can create shipment for only one item from order. In this case when we try to create shipping label with shipment ("Create Shipping Label" Checkbox), the system requires to add all products to package (including products, which wasn't added to shipment) and validation fails.

Related Pull Requests

Fixed Issues (if relevant)

magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

Have configured shipping method with ability to create Shipping Labels
Have 2 products with available in 2 or more sources
Add to cart and order both products with shipping method from point 0.
Create shipment from admin panel: select source and enter qty only for one product (qty for second product should be 0)
Click Proceed to Shipment.
Check that only one product in Items to Ship
Check checkbox "Create Shipping Label" and press "Submit Shipment..."
Click "Add Products to Package". In the list there are both products.
When we add to package only one product - the next button is disabled.

Expected result:
7. In the list there is only one product
8. The "Next" button is enabled

Questions or comments

Contribution checklist (*)

[*] Pull request has a meaningful description of its purpose
[*] All commits are accompanied by meaningful commit messages
[*] All new or changed code is covered with unit/integration tests (if applicable)
[*] All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Fixed creating shipping labels in part-shipment #29552: Fixed creating shipping labels in part-shipment

m2-assistant · 2020-04-09T10:33:33Z

Hi @NikolasSumrak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

sidolov · 2020-08-14T20:30:24Z

@magento create issue

sidolov

@NikolasSumrak could you please cover changes with automated test?

engcom-Hotel · 2020-09-17T15:07:15Z

@magento run all tests

engcom-Hotel · 2020-09-17T15:34:19Z

It is complicated to create MFTF for this change, because of the security issue with storing shipment account credentials. Integration test checks that JS code rendered.

gabrieldagama

Hi @engcom-Hotel, thanks for adding test coverage, please have a look at my comments below.

dev/tests/integration/testsuite/Magento/Shipping/Block/Adminhtml/Order/AddToPackageTest.php

…Sumrak

engcom-Hotel · 2020-09-22T12:46:27Z

@magento run all tests

magento-engcom-team · 2020-09-23T10:11:31Z

Hi @gabrieldagama, thank you for the review.
ENGCOM-8253 has been created to process this Pull Request
✳️ @gabrieldagama, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Bravo

Hello @NikolasSumrak

Looks like the changes provided in this PR do not fix the original issue
The Save button is still disabled when only one product is added to package

Pull Request state was updated. Re-review required.

engcom-Hotel · 2020-09-29T14:06:30Z

Hello @NikolasSumrak, could you please check the previous comment and provide additional information for reproducing process or check provided solution.
Thank you.

engcom-Hotel · 2020-10-15T06:24:48Z

Will check it

engcom-Bravo · 2020-10-15T12:27:40Z

@gabrieldagama Can you please review the latest changes? Thank you

magento-engcom-team · 2020-10-15T12:47:23Z

Hi @gabrieldagama, thank you for the review.
ENGCOM-8253 has been created to process this Pull Request
✳️ @gabrieldagama, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Bravo · 2020-10-16T11:09:54Z

✔️ QA Passed

Manual testing scenario

Install Inventory
Configure a Shipping method with the ability to Create Shipping Label, UPS for example
Create two Sources and Assign them to one Stock
Create two Products, and Assign two previously created Sources to each of them
Submit an order containing previously created Products and selecting UPS Shipping Method
Go to Ship. Select Source, set Qty To Deduct 1 for one Product and 0 for the other Product. Click Proceed to Shipment
Assert that only 1 Product is listed in Items to Ship
Check Create Shiping Label checkbox and click Submit Shipment
Click Add Products to Package. Assert that only one product appeared in the list of Products
Check the product and click Add selected Product(s) to Package
Assert that the Save button is active and available

BEFORE APPLYING CHANGES PROVIDED IN THIS PR
Two products were available in Create Packages window, despite that 0 quantity has been set

And before Adding both Products to Package, Save button was not available

gabrieldagama · 2020-10-19T12:17:26Z

@magento run all tests

gabrieldagama · 2020-10-20T08:59:28Z

@magento run all tests

m2-assistant · 2020-10-21T20:38:08Z

Hi @NikolasSumrak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Fixed creating shipping labels in part-shipment

eb8cd70

magento-engcom-team added Area: Frontend Component: Shipping labels Apr 9, 2020

ghost added the Progress: pending review label Apr 9, 2020

magento-engcom-team added the Release Line: 2.4 label Apr 9, 2020

m2-assistant bot mentioned this pull request Aug 14, 2020

[Issue] Fixed creating shipping labels in part-shipment #29552

Closed

sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 14, 2020

sidolov requested changes Aug 20, 2020

View reviewed changes

ghost assigned sidolov Aug 20, 2020

ghost added Progress: needs update and removed Progress: pending review labels Aug 20, 2020

engcom-Hotel self-assigned this Sep 10, 2020

engcom-Hotel and others added 2 commits September 17, 2020 18:05

Integration test has been added

b213915

Merge branch '2.4-develop' into 2.4-develop

40e4ac0

engcom-Hotel requested a review from sidolov September 21, 2020 06:17

ghost added Progress: pending review and removed Progress: needs update labels Sep 21, 2020

gabrieldagama suggested changes Sep 21, 2020

View reviewed changes

dev/tests/integration/testsuite/Magento/Shipping/Block/Adminhtml/Order/AddToPackageTest.php Outdated Show resolved Hide resolved

dev/tests/integration/testsuite/Magento/Shipping/Block/Adminhtml/Order/AddToPackageTest.php Outdated Show resolved Hide resolved

ghost assigned gabrieldagama Sep 21, 2020

ghost added Progress: needs update and removed Progress: pending review labels Sep 21, 2020

engcom-Hotel and others added 3 commits September 22, 2020 15:44

Code refactoring, fixture has been updated.

fee7c0c

Merge remote-tracking branch 'NikolasSumrak/2.4-develop' into Nikolas…

0694d79

…Sumrak

Merge branch '2.4-develop' into 2.4-develop

78a897b

ghost added the Progress: ready for testing label Sep 23, 2020

engcom-Bravo self-assigned this Sep 24, 2020

engcom-Bravo requested changes Sep 25, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: ready for testing labels Sep 25, 2020

engcom-Hotel requested a review from engcom-Bravo October 15, 2020 12:25

engcom-Bravo requested a review from gabrieldagama October 15, 2020 12:27

gabrieldagama approved these changes Oct 15, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Oct 15, 2020

gabrieldagama added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Oct 15, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Oct 16, 2020

engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Oct 16, 2020

ghost added Progress: accept and removed Progress: testing in progress labels Oct 16, 2020

Merge branch '2.4-develop' into 2.4-develop

25422c2

magento-engcom-team pushed a commit that referenced this pull request Oct 21, 2020

ENGCOM-8253: Fixed creating shipping labels in part-shipment #27672

e3d469f

magento-engcom-team merged commit 5b564c5 into magento:2.4-develop Oct 21, 2020

alinalexandru mentioned this pull request Jun 7, 2022

Can't create label for existing shipment #34964

Closed

5 tasks

Fixed creating shipping labels in part-shipment #27672

Fixed creating shipping labels in part-shipment #27672

Uh oh!

Conversation

NikolasSumrak commented Apr 9, 2020 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Apr 9, 2020

Uh oh!

sidolov commented Aug 14, 2020

Uh oh!

sidolov left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel commented Sep 17, 2020

Uh oh!

engcom-Hotel commented Sep 17, 2020

Uh oh!

gabrieldagama left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

engcom-Hotel commented Sep 22, 2020

Uh oh!

magento-engcom-team commented Sep 23, 2020

Uh oh!

engcom-Bravo left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel commented Sep 29, 2020

Uh oh!

engcom-Hotel commented Oct 15, 2020

Uh oh!

engcom-Bravo commented Oct 15, 2020

Uh oh!

magento-engcom-team commented Oct 15, 2020

Uh oh!

engcom-Bravo commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Manual testing scenario

Uh oh!

gabrieldagama commented Oct 19, 2020

Uh oh!

gabrieldagama commented Oct 20, 2020

Uh oh!

m2-assistant bot commented Oct 21, 2020

Uh oh!

Uh oh!

NikolasSumrak commented Apr 9, 2020 •

edited by m2-assistant bot

Loading

engcom-Bravo commented Oct 16, 2020 •

edited

Loading