Skip to content

Resolve No validate "Day" in PayPal Express Checkout Settings issue24302 #24303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve No validate "Day" in PayPal Express Checkout Settings #24302: No validate "Day" in PayPal Express Checkout Settings

Solution: use "validate-zero-or-greater validate-digits" in app/code/Magento/Paypal/etc/adminhtml/system/express_checkout.xml

Fixed Issues (if relevant)

  1. No validate "Day" in PayPal Express Checkout Settings #24302: No validate "Day" in PayPal Express Checkout Settings

Manual testing scenarios (*)

  1. Go to backend
  2. Store->Configuration
  3. Sales-> Payment Methods
  4. In "PayPal Express Checkout", "Basic Settings - PayPal Express Checkout"
  5. Choose "Payment Action" is "Order"
  6. Fill "one" in "Authorization Honor Period (days)" "Order Valid Period (days)"
  7. Save

image

Expected result

  1. Can not save because it is not number

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 27, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@swnsma swnsma added Award: bug fix Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Aug 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-5712 has been created to process this Pull Request
✳️ @swnsma, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch self-assigned this Aug 28, 2019
@dmytro-ch
Copy link
Contributor

dmytro-ch commented Aug 28, 2019

Hi @edenduong,
please, combine the pull requests with such improvements in one single pull request on order make it easier to process these PRs by Community Engineering Team.
#24313
#24309
#24303
#24305
Also, feel free to create pull requests for minor fixes and obvious improvements without opening the issues.

Thank you!

@dmytro-ch dmytro-ch closed this Aug 28, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 28, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @edenduong
Thank you for your contribution. This pull request has been combined (merged) with #24313 to optimize pull requests queue on magento/magento2 repository
Closing this pull request.

@m2-assistant
Copy link

m2-assistant bot commented Aug 28, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team added a commit to edenduong/magento2 that referenced this pull request Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Paypal Progress: on hold Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No validate "Day" in PayPal Express Checkout Settings
4 participants