Skip to content

Update AdvancedSearch ReadMe #24176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Update AdvancedSearch ReadMe #24176

merged 2 commits into from
Aug 27, 2019

Conversation

diazwatson
Copy link
Contributor

Description (*)

Updates ReadMe for the Magento_AdvancedSearch module.

Fixed Issues (if relevant)

  1. magento/devdocs README content for modules - work in M2 Code devdocs#4451: README content for modules - work in M2 Code

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@diazwatson diazwatson added Release Line: 2.3 Component: AdvancedSearch Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Aug 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 18, 2019

Hi @diazwatson. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Space 48 Partner Space48 contribution partners-contribution Pull Request is created by Magento Partner labels Aug 18, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5658 has been created to process this Pull Request

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on these READMEs @diazwatson! I made some minor editorial suggestions.

@diazwatson
Copy link
Contributor Author

Thanks to you @jeff-matthews for taking the time to CR this.
Requested changes are now done.

@magento-engcom-team
Copy link
Contributor

Hi @jeff-matthews, thank you for the review.
ENGCOM-5658 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Aug 23, 2019
@engcom-Alfa
Copy link
Contributor

QA not applicable

@ghost ghost added the Progress: accept label Aug 23, 2019
@magento-engcom-team magento-engcom-team merged commit b7ed020 into magento:2.3-develop Aug 27, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 27, 2019

Hi @diazwatson, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: AdvancedSearch Partner: Space 48 Partner Space48 contribution partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants