Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

README content for modules - work in M2 Code #4451

Closed
lorikrell opened this issue May 7, 2019 · 23 comments · Fixed by magento/magento2#31969
Closed

README content for modules - work in M2 Code #4451

lorikrell opened this issue May 7, 2019 · 23 comments · Fixed by magento/magento2#31969
Assignees
Labels
2.x Special achievement High-value contributions that earn higher rewards and special attention

Comments

@lorikrell
Copy link

lorikrell commented May 7, 2019

Topic clarification/correction request

Topic Link

All modules documented in the Open Source and Commerce
of the Module Reference Guide pull the content from the READMEs in Magento 2 code. To add content, create PRs to Magento 2 core!

Solution

We need Modules documented in the Magento 2 source code.
2.4: https://github.com/magento/magento2/tree/2.4-develop/app/code/Magento

  • We have a template for you to use: Magento module readme template
  • As you add PRs to Magento 2 core, add a link to this issue.
  • We can review your PR in Magento 2.
  • The merged PRs will be pulled by our doc process, automatically adding content to DevDocs!
@lorikrell lorikrell added 2.x Contribution Day Issues and PRs for Contribution Days! Groomed and ready to work. Special achievement High-value contributions that earn higher rewards and special attention labels May 7, 2019
@diazwatson
Copy link
Contributor

Hi guys, can I have this assigned to me please?

@jeff-matthews
Copy link
Contributor

@diazwatson, assigned to you. It looks like we still need to provide you with a README template before you can start work.

@dshevtsov, is there a template available?

@diazwatson
Copy link
Contributor

Yes please.
From what I can see Readme files need to be created for all modules in m2 repo, then (once change merged) referenced in these 2 pages. Is this correct?

@jeff-matthews
Copy link
Contributor

Yes, that's correct @diazwatson.

@dshevtsov
Copy link
Collaborator

@jeff-matthews, the template is in our internal wiki and has to be published.

@jeff-matthews
Copy link
Contributor

@diazwatson, I attached the template to this comment. GitHub won't accept a Markdown (.md) file attachment, so I changed it to .txt. After you download it, just change the extension to .md.

module-readme-template.txt

@diazwatson
Copy link
Contributor

Thanks for sorting that @jeff-matthews I think I have everything to start

@jeff-matthews
Copy link
Contributor

No problem! Thanks for volunteering to work on this. I also created a public gist of the template: https://gist.github.com/magento-docbot/dfb8cc7db6519da14fc92b890d49b7d3

@keharper
Copy link
Contributor

Make sure any links that point to devdocs contain the proper version in the URL. The template shows links with "2.1".

@jeff-matthews
Copy link
Contributor

Thanks for pointing that out @keharper. I just fixed the gist, but the file attached to my previous comment still has the old 2.1 links.

@dshevtsov
Copy link
Collaborator

Seemed like an unintentional closure via a closing keyword.

@dshevtsov dshevtsov reopened this Jul 29, 2021
@chiranjeevi-cj chiranjeevi-cj removed their assignment Jul 29, 2021
@BarnyShergold BarnyShergold self-assigned this Aug 27, 2021
@korovitskyi korovitskyi removed their assignment Sep 3, 2021
@dshevtsov
Copy link
Collaborator

The Module reference Guide was moved to https://developer.adobe.com/commerce/php/module-reference/.

@dshevtsov dshevtsov removed Help Wanted Help wanted for issue/PR Progress: dev in progress labels Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Special achievement High-value contributions that earn higher rewards and special attention
Projects
None yet
Development

Successfully merging a pull request may close this issue.