Skip to content

Conversation

@edenduong
Copy link
Contributor

Description (*)

class app/code/Magento/Bundle/Setup/Patch/Data/ApplyAttributesUpdate.php should use \Magento\Catalog\Model\Product\Type::TYPE_BUNDLE instead of fix string "bundle"

Need use the Constant which be defined by \Magento\Catalog\Model\Product\Type instead of fix string "bundle"

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Check class ApplyAttributesUpdate in "app/code/Magento/Bundle/Setup/Patch/Data/ApplyAttributesUpdate.php"
  2. Check code: doesn't use the fix string 'bundle'. Replaced by \Magento\Catalog\Model\Product\Type::TYPE_BUNDLE

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 27, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@edenduong edenduong changed the title class ApplyAttributesUpdate in app/code/Magento/Bundle/Setup/Patch/Data/ApplyAttributesUpdate.php should use \Magento\Catalog\Model\Product\Type::TYPE_BUNDLE instead of fixing "bundle" class ApplyAttributesUpdate should use \Magento\Catalog\Model\Product\Type::TYPE_BUNDLE instead of fixing "bundle" Jul 27, 2019
@ghost ghost assigned ihor-sviziev Jul 27, 2019
@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5499 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Jul 29, 2019
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Aug 1, 2019
…Model\Product\Type::TYPE_BUNDLE instead of fixing "bundle" magento#23919
@magento-engcom-team magento-engcom-team merged commit 83963ee into magento:2.3-develop Aug 1, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 1, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants