Skip to content

Conversation

@edenduong
Copy link
Contributor

@edenduong edenduong commented Jul 26, 2019

Description (*)

  1. Resolve Report->Product->Downloads has wrong ACL #23900: Report->Product->Downloads has wrong ACL

Solution: Change to correct ACL:

const ADMIN_RESOURCE = 'Magento_Reports::downloads';

in app/code/Magento/Reports/Controller/Adminhtml/Report/Product/Downloads.php

Fixed Issues (if relevant)

  1. Report->Product->Downloads has wrong ACL #23900: Report->Product->Downloads has wrong ACL

Manual testing scenarios (*)

  1. Go to Store->Configuration, Advanced->Admin, Set "Add Secret Key to URLs" : "No"

image

  1. Create New Role with followings Permission:
    image
    Check label "Products" but uncheck "Downloads"
  2. Create New Admin User and Assign to this role.
  3. Logout current admin user and login to New admin user.
  4. Go to this url : http://[Magento 2 domain]/admin/reports/report_product/downloads
    Expected Result: Can not access

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 26, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@edenduong edenduong requested a review from Stepa4man July 28, 2019 14:11
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-5505 has been created to process this Pull Request
✳️ @aleron75, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ghost ghost assigned Stepa4man Jul 29, 2019
@Stepa4man Stepa4man removed their assignment Jul 29, 2019
@Stepa4man Stepa4man removed their assignment Jul 29, 2019
@magento-engcom-team
Copy link
Contributor

Hi @Stepa4man, thank you for the review.
ENGCOM-5505 has been created to process this Pull Request
✳️ @Stepa4man, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@Stepa4man Stepa4man requested review from Stepa4man and removed request for Stepa4man July 29, 2019 08:33
@engcom-Delta engcom-Delta self-assigned this Jul 29, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Aug 1, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Aug 1, 2019
@edenduong
Copy link
Contributor Author

@sivaschenko : Could I receive Bug fixed reward? Thank you :)

@sidolov sidolov added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report->Product->Downloads has wrong ACL

6 participants