Skip to content

Conversation

@Jeroenll
Copy link
Member

Description (*)

Adding an url using a variable will remove a custom added url key when switching between show and hide editor.

Fixed Issues (if relevant)

None I could find.

Manual testing scenarios (*)

  1. Open a CMS page and hide the editor so raw html can be inserted.
  2. Insert <p><a href="{{config path="web/secure/base_url"}}custom-key">custom</a></p>
  3. Click show/hide editor twice and you're back in the raw input mode.
  4. Your added custom-key is now removed.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 24, 2019

Hi @JeroenVanLeusden. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@pmclain
Copy link
Contributor

pmclain commented Jul 29, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @pmclain. Thank you for your request. I'm working on Magento instance for you

@pmclain pmclain self-requested a review July 29, 2019 12:34
@magento-engcom-team
Copy link
Contributor

Hi @pmclain, here is your new Magento instance.
Admin access: https://pr-23845.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@pmclain
Copy link
Contributor

pmclain commented Jul 29, 2019

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @pmclain. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @pmclain, here is your Magento instance.
Admin access: https://i-23845-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ghost ghost assigned pmclain Jul 29, 2019
@magento-engcom-team
Copy link
Contributor

Hi @pmclain, thank you for the review.
ENGCOM-5508 has been created to process this Pull Request
✳️ @pmclain, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Jul 30, 2019
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Aug 1, 2019
@magento-engcom-team magento-engcom-team merged commit 84ab701 into magento:2.3-develop Aug 1, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 1, 2019

Hi @JeroenVanLeusden, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Aug 1, 2019
@Jeroenll Jeroenll deleted the JeroenVanLeusden-patch-5 branch September 9, 2019 13:01
@VladimirZaets VladimirZaets added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Lib/Frontend Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Partner: H&O partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants